[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D6047: WIP: Support XDG v6
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-06-23 11:29:42
Message-ID: 20170623112942.25213.F53196612AF59A31 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> graesslin wrote in xdgshell_interface.h:80
> @davidedmundson  for the ping you could check the old wl_shell_surface \
> implementation in KWayland.

the implementation here in xdgshell_interface is basically copied over the kwayland  \
wl_shell_surface.

the code pasted above, is the only kwin part i found that was managing pings in any \
way, which is the x11 implementation (Client) i guess ShellClient will have to have \
something along the lines using the kwayland implementations, tough casing between \
the possible interfaces exposed (wl_shell, xdgshellv5 and xdgshellv6)

> graesslin wrote in xdgshell_interface.h:75
> what is "gravity"?

as far i understood, it's an hint that tells the window the direction it prefers to \
popup, so like "please dear compositor make it show below the point i asked to", or \
at the left, or whatever hint that the compositor can choose to ignore

REVISION DETAIL
  https://phabricator.kde.org/D6047

To: davidedmundson, #plasma
Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6047" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6047#inline-26148" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">graesslin</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">xdgshell_interface.h:80</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;"><a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a>  for the ping \
you could check the old wl_shell_surface implementation in KWayland.</p></div></div> \
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the \
implementation here in xdgshell_interface is basically copied over the kwayland  \
wl_shell_surface.</p>

<p style="padding: 0; margin: 8px;">the code pasted above, is the only kwin part i \
found that was managing pings in any way, which is the x11 implementation (Client)<br \
/> i guess ShellClient will have to have something along the lines using the kwayland \
implementations, tough casing between the possible interfaces exposed (wl_shell, \
xdgshellv5 and xdgshellv6)</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D6047#inline-26146" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">graesslin</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">xdgshell_interface.h:75</span></div> \
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; \
margin: 8px;">what is &quot;gravity&quot;?</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">as far i understood, it&#039;s \
an hint that tells the window the direction it prefers to popup, so like &quot;please \
dear compositor make it show below the point i asked to&quot;, or at the left, or \
whatever<br /> hint that the compositor can choose to \
ignore</p></div></div></div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D6047" \
rel="noreferrer">https://phabricator.kde.org/D6047</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>graesslin, mart, plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]