[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 130138: Set QT_NO_EXCEPTIONS when building *.mm files
From: Harald Fernengel <harry () kdevelop ! org>
Date: 2017-06-01 13:27:27
Message-ID: 20170601132727.3028.37196 () mimi ! kde ! org
[Download RAW message or body]
--===============7598141163350256140==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130138/
-----------------------------------------------------------
(Updated June 1, 2017, 1:27 p.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
Repository: sonnet
Description
-------
Apparently, exceptions are disabled when building *.mm files.
The alternative would be to set
target_compile_options(sonnet_nsspellchecker PRIVATE "-fexceptions")
in order to force exception to be on for *.mm files. However, since
exceptions aren't used in the code, let's just build without.
Diffs
-----
src/plugins/nsspellchecker/CMakeLists.txt f8c99d1ea080b1e28f60c57f8f588ed059c96711
Diff: https://git.reviewboard.kde.org/r/130138/diff/
Testing
-------
Thanks,
Harald Fernengel
--===============7598141163350256140==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130138/">https://git.reviewboard.kde.org/r/130138/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Harald Fernengel.</div>
<p style="color: grey;"><i>Updated June 1, 2017, 1:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
sonnet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Apparently, exceptions are disabled when building *.mm files. The \
alternative would be to set
target_compile_options(sonnet_nsspellchecker PRIVATE "-fexceptions")
in order to force exception to be on for *.mm files. However, since
exceptions aren't used in the code, let's just build without.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/nsspellchecker/CMakeLists.txt <span style="color: \
grey">(f8c99d1ea080b1e28f60c57f8f588ed059c96711)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130138/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7598141163350256140==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic