[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D6047: WIP: Support XDG v6
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-06-01 12:29:25
Message-ID: 20170601122856.126589.FB4365FD6D846522 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  Comments for Marco:

INLINE COMMENTS

> xdgshell_interface.h:80
> 
> +    void ping();
> +

We need the serial Ids here, otherwise it's not very usable; especially as the pong \
doesn't have an elapsed time.

A kjob like API wrapping this might be perfect for here?

> xdgshell_interface_p.h:41
> +    quint32 pingSerial = 0;
> +    QScopedPointer<QTimer> pingTimer;
> +

I don't understand this timer, all it's used for is for making us not emit a pong if \
it comes in after a timeout?

REVISION DETAIL
  https://phabricator.kde.org/D6047

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6047" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Comments for Marco:</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D6047#inline-24840" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">xdgshell_interface.h:80</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: \
#aa4000">void</span> <span style="color: #004012">ping</span><span \
class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We \
need the serial Ids here, otherwise it&#039;s not very usable; especially as the pong \
doesn&#039;t have an elapsed time.</p>

<p style="padding: 0; margin: 8px;">A kjob like API wrapping this might be perfect \
for here?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6047#inline-24841" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">xdgshell_interface_p.h:41</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
class="n">quint32</span> <span class="n">pingSerial</span> <span style="color: \
#aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span class="n">QScopedPointer</span><span style="color: \
#aa2211">&lt;</span><span class="n">QTimer</span><span style="color: \
#aa2211">&gt;</span> <span class="n">pingTimer</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">I don&#039;t understand this timer, all it&#039;s used for is for \
making us not emit a pong if it comes in after a \
timeout?</p></div></div></div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D6047" \
rel="noreferrer">https://phabricator.kde.org/D6047</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, Frameworks, ZrenBot, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]