[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D6041: Port a bunch of classes away from Plasma::Package
From:       Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date:       2017-05-31 10:56:11
Message-ID: 20170531105610.3964.1A8E2830B197059A () phabricator ! kde ! org
[Download RAW message or body]

apol marked 2 inline comments as done.
apol added inline comments.

INLINE COMMENTS

> mart wrote in appletquickitem.h:105
> despite the warning in the header, this ended up being an exported symbol, so \
> binary compatibility rules apply here too. Plasma::Package appletPackage() const; \
> has to stay, eventually deprecated and a new KPackage::Package appletPackage() \
> const; added.

Okay, will fix in a next patch. Please note nobody is using these methods and we \
could possibly scrap altogether the storing of appletPackage and coronaPackage.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6041

To: apol, #frameworks, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">apol marked 2 inline comments as done.<br />apol added inline \
comments. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6041" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6041#inline-24811" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">mart</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">appletquickitem.h:105</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">despite the warning in the \
header, this ended up being an exported symbol, so binary compatibility rules apply \
here too.<br /> Plasma::Package appletPackage() const; has to stay, eventually \
deprecated and a new KPackage::Package appletPackage() const; added.</p></div></div> \
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Okay, will fix in a next patch. Please note nobody is using these methods and \
we could possibly scrap altogether the storing of appletPackage and \
coronaPackage.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6041" \
rel="noreferrer">https://phabricator.kde.org/D6041</a></div></div><br \
/><div><strong>To: </strong>apol, Frameworks, Plasma, mart<br /><strong>Cc: \
</strong>mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]