[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D5247: [ModelContextMenu] Silence warnings
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-03-29 16:41:33
Message-ID: differential-rev-PHID-DREV-dytzgezyv7dqoqzcppbn-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  When using a regular JavaScript Array as model and omitting certain roles (e.g. not \
having a "text" for a separator) it would throw a warning.

TEST PLAN
  Color picker no longer throws warnings in its menu (I use sections and separators \
here).  Widget explorer filter and download widgets buttons still work

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5247

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml

To: broulik, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />Restricted Application \
added projects: Plasma, Frameworks.<br />Restricted Application added subscribers: \
Frameworks, plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5247" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>When \
using a regular JavaScript Array as model and omitting certain roles (e.g. not having \
a &quot;text&quot; for a separator) it would throw a warning.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Color picker no longer throws warnings in \
its menu (I use sections and separators here).<br /> Widget explorer filter and \
download widgets buttons still work</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5247" \
rel="noreferrer">https://phabricator.kde.org/D5247</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/declarativeimports/plasmacomponents/qml/ModelContextMenu.qml</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, \
Frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]