'Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-mac
Subject:    Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound
From:       René J.V. Bertin <rjvbertin () gmail ! com>
Date:       2017-03-16 16:55:59
Message-ID: 20170316165559.17279.82665 () mimi ! kde ! org
[Download RAW message or body]

--===============1664988723461021293==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128043/#review102883
-----------------------------------------------------------



https://phabricator.kde.org/D5070

- René J.V. Bertin


On June 9, 2016, 7:52 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128043/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 7:52 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> This is a follow-up to discussion on the plasma-devel ML. When not running under a \
> Plasma session it would be preferable if generic alert sounds are (can be) \
> delivered using the default system sound. The easiest way to do that is to call \
> `QApplication::beep()` ; at least on OS X this will play the user's selected alert \
> sound. 
> I have implemented this for now by assuming the existence of a virtual (relative) \
> `beep` sound file that always plays the default sound.  
> In addition, this patch provides better warning feedback if a soundfile isn't found \
> (making it easier to figure out which alert is misconfigured), and will play the \
> sysbeep in that case (so that the alert doesn't go lost if it's sound-only). \
> Finally, no Phonon::AudioOutput object is created until that is actually required. 
> 
> Diffs
> -----
> 
> src/notifybyaudio.cpp 903e996 
> 
> Diff: https://git.reviewboard.kde.org/r/128043/diff/
> 
> 
> Testing
> -------
> 
> Works as expected on OS X 10.9.5
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
> 


--===============1664988723461021293==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128043/">https://git.reviewboard.kde.org/r/128043/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">https://phabricator.kde.org/D5070</p></pre>  <br />









<p>- René J.V. Bertin</p>


<br />
<p>On June 9th, 2016, 7:52 p.m. CEST, René J.V. Bertin wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Software on Mac OS X and KDE Frameworks.</div>
<div>By René J.V. Bertin.</div>


<p style="color: grey;"><i>Updated June 9, 2016, 7:52 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a follow-up to discussion on the plasma-devel \
ML. When not running under a Plasma session it would be preferable if generic alert \
sounds are (can be) delivered using the default system sound. The easiest way to do \
that is to call <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">QApplication::beep()</code> ; \
at least on OS X this will play the user's selected alert sound.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I have implemented this for now by assuming the existence of a virtual \
(relative) <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">beep</code> sound file that \
always plays the default sound. </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">In addition, this patch \
provides better warning feedback if a soundfile isn't found (making it easier to \
figure out which alert is misconfigured), and will play the sysbeep in that case (so \
that the alert doesn't go lost if it's sound-only). Finally, no Phonon::AudioOutput \
object is created until that is actually required.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works as expected on OS X 10.9.5</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/notifybyaudio.cpp <span style="color: grey">(903e996)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128043/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============1664988723461021293==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic