[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D4947: [KTextEditor] Expose additional internal View's functionality to the public API
From:       John Salatas <noreply () phabricator ! kde ! org>
Date:       2017-03-05 20:57:10
Message-ID: differential-rev-PHID-DREV-74kqcop4jgr6fqfiwmli-req () phabricator ! kde ! org
[Download RAW message or body]

jsalatas created this revision.
Restricted Application added a subscriber: kwrite-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  I'm creating a diff/patch frontend similar to Kompare but using KTextEditor to \
display/edit source/destination files. In order to be able to sync the scrolling \
positions of the two Views and also to overlay diff indicators (see screenshot), I'm \
exposing the following:  
  - scrollPos: scrolls the View to a cursor position
  - scrollColumns: scrolls the View to a column
  - maxStartPos: returns the cursor position of the maximum vertical scroll position
  - startLine: returns the first visible line in the View
  - endLine: returns the last visible line in the View
  - textareaRect: returns the View's text area rectangle excluding border, \
scrollbars, etc.  
  F2705627: Screenshot_20170305_124152.png <https://phabricator.kde.org/F2705627>

TEST PLAN
  Already tested in my app. It works :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4947

AFFECTED FILES
  src/include/ktexteditor/view.h
  src/view/kateview.cpp
  src/view/kateview.h

To: jsalatas, #ktexteditor, #frameworks
Cc: kwrite-devel


[Attachment #3 (text/html)]

<table><tr><td style="">jsalatas created this revision.<br />Restricted Application \
added a subscriber: kwrite-devel.<br />Restricted Application added a project: \
Frameworks. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4947" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>I&#039;m \
creating a diff/patch frontend similar to Kompare but using KTextEditor to \
display/edit source/destination files. In order to be able to sync the scrolling \
positions of the two Views and also to overlay diff indicators (see screenshot), \
I&#039;m exposing the following:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">scrollPos: scrolls the View to a cursor position</li>
<li class="remarkup-list-item">scrollColumns: scrolls the View to a column</li>
<li class="remarkup-list-item">maxStartPos: returns the cursor position of the \
maximum vertical scroll position</li> <li class="remarkup-list-item">startLine: \
returns the first visible line in the View</li> <li \
class="remarkup-list-item">endLine: returns the last visible line in the View</li> \
<li class="remarkup-list-item">textareaRect: returns the View&#039;s text area \
rectangle excluding border, scrollbars, etc.</li> </ul>

<p><a href="https://phabricator.kde.org/F2705627" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F2705627: \
Screenshot_20170305_124152.png</a></p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Already tested in my app. It works :)</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4947" \
rel="noreferrer">https://phabricator.kde.org/D4947</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/include/ktexteditor/view.h<br /> \
src/view/kateview.cpp<br /> src/view/kateview.h</div></div></div><br \
/><div><strong>To: </strong>jsalatas, KTextEditor, Frameworks<br /><strong>Cc: \
</strong>kwrite-devel<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]