--===============1489956160449827196== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129986/ ----------------------------------------------------------- (Updated March 5, 2017, 9:04 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Changes ------- Submitted with commit 143fbd2cd9d5698420ec246f03a4aea24d9d33b3 by Jean-Baptiste Mardelle to branch master. Bugs: 371685 https://bugs.kde.org/show_bug.cgi?id=371685 Repository: kio Description ------- Using a KUrlRequester to select a file to save is not currently working. The file dialog is always opening in "open" mode, never in "save" mode. My patch adds a method to call setAcceptMode on the file dialog. Some users reported that the current behavior completely breaks the functionnality on some platforms(Gnome), making it impossible to select a non existing file. Diffs ----- src/widgets/kurlrequester.h 51c1259 src/widgets/kurlrequester.cpp 62e1fea Diff: https://git.reviewboard.kde.org/r/129986/diff/ Testing ------- Tested locally, the dialog opening from the KUrlRequester is now a proper "save" dialog Thanks, Jean-Baptiste Mardelle --===============1489956160449827196== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129986/

This change has been marked as submitted.

Review request for KDE Frameworks and David Faure.
By Jean-Baptiste Mardelle.

Updated March 5, 2017, 9:04 p.m.

Changes

Submitted with commit 143fbd2cd9d5698420ec246f03a4aea24d9d33b3 by Jean-Baptiste Mardelle to branch master.
Bugs: 371685
Repository: kio

Description 

Using a KUrlRequester to select a file to save is not currently working. The file dialog is always opening in "open" mode, never in "save" mode. My patch adds a method to call setAcceptMode on the file dialog. Some users reported that the current behavior completely breaks the functionnality on some platforms(Gnome), making it impossible to select a non existing file.

Testing 

Tested locally, the dialog opening from the KUrlRequester is now a proper "save" dialog

Diffs

  • src/widgets/kurlrequester.h (51c1259)
  • src/widgets/kurlrequester.cpp (62e1fea)

View Diff
--===============1489956160449827196==--