[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129986: KUrlRequester does not allow proper save filedialog
From: David Faure <faure () kde ! org>
Date: 2017-03-05 20:01:54
Message-ID: 20170305200154.27981.65736 () mimi ! kde ! org
[Download RAW message or body]
--===============3633372668059831411==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129986/#review102728
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On March 5, 2017, 8 p.m., Jean-Baptiste Mardelle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129986/
> -----------------------------------------------------------
>
> (Updated March 5, 2017, 8 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Bugs: 371685
> https://bugs.kde.org/show_bug.cgi?id=371685
>
>
> Repository: kio
>
>
> Description
> -------
>
> Using a KUrlRequester to select a file to save is not currently working. The file \
> dialog is always opening in "open" mode, never in "save" mode. My patch adds a \
> method to call setAcceptMode on the file dialog. Some users reported that the \
> current behavior completely breaks the functionnality on some platforms(Gnome), \
> making it impossible to select a non existing file.
>
> Diffs
> -----
>
> src/widgets/kurlrequester.h 51c1259
> src/widgets/kurlrequester.cpp 62e1fea
>
> Diff: https://git.reviewboard.kde.org/r/129986/diff/
>
>
> Testing
> -------
>
> Tested locally, the dialog opening from the KUrlRequester is now a proper "save" \
> dialog
>
> Thanks,
>
> Jean-Baptiste Mardelle
>
>
--===============3633372668059831411==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129986/">https://git.reviewboard.kde.org/r/129986/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Faure</p>
<br />
<p>On March 5th, 2017, 8 p.m. UTC, Jean-Baptiste Mardelle wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Jean-Baptiste Mardelle.</div>
<p style="color: grey;"><i>Updated March 5, 2017, 8 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=371685">371685</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Using a KUrlRequester to select a file to save is not \
currently working. The file dialog is always opening in "open" mode, never in "save" \
mode. My patch adds a method to call setAcceptMode on the file dialog. Some users \
reported that the current behavior completely breaks the functionnality on some \
platforms(Gnome), making it impossible to select a non existing file.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested locally, the dialog opening from the \
KUrlRequester is now a proper "save" dialog</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/kurlrequester.h <span style="color: grey">(51c1259)</span></li>
<li>src/widgets/kurlrequester.cpp <span style="color: grey">(62e1fea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129986/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3633372668059831411==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic