[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128426: Support OpenGL 3.2 Core profile in FadingNode shaders
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2017-03-01 2:33:00
Message-ID: 20170301023300.25256.2515 () mimi ! kde ! org
[Download RAW message or body]
--===============7380611518338626935==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128426/
-----------------------------------------------------------
(Updated March 1, 2017, 2:33 a.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks and Plasma.
Repository: plasma-framework
Description
-------
Qt has two shaders for all items; one for when running OpenGL3.2+ without backwards compatibility (i.e \
running CoreProfile) and one that supports more legacy systems. (see the shaders directory and the \
versions ending with _core)
core profile is only used if explicitly by the app enabled when creating the GL context.
Something we don't currently do in Plasma, but a 3d party user could be doing.
Long term it's also something I want to do in Plasma optionally as it gives a 15Mb memory saving with \
Mesa.
This patch updates our material to provide the right shader for the
given version matching the behavior of
QSGShaderSourceBuilder::resolveShaderPath which Qt uses internally.
Diffs
-----
src/declarativeimports/core/fadingnode.cpp 88b7310641f58c2b74fe61d2c5a97847cf7dc3b8
Diff: https://git.reviewboard.kde.org/r/128426/diff/
Testing
-------
ran krunner with
+ QSurfaceFormat format;
+ format.setVersion(3,2);
+ format.setProfile(QSurfaceFormat::CoreProfile);
+ QSurfaceFormat::setDefaultFormat(format);
and it still works.
plasmashell unchanged (so still requesting an GL 2.0 context) also still works.
Thanks,
David Edmundson
--===============7380611518338626935==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128426/">https://git.reviewboard.kde.org/r/128426/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 1, 2017, 2:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Qt has two shaders for all items; one for \
when running OpenGL3.2+ without backwards compatibility (i.e running CoreProfile) and one that supports \
more legacy systems. (see the shaders directory and the versions ending with _core)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">core \
profile is only used if explicitly by the app enabled when creating the GL context. </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Something \
we don't currently do in Plasma, but a 3d party user could be doing.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Long term it's also \
something I want to do in Plasma optionally as it gives a 15Mb memory saving with Mesa.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
patch updates our material to provide the right shader for the given version matching the behavior of
QSGShaderSourceBuilder::resolveShaderPath which Qt uses internally.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">ran krunner with + QSurfaceFormat \
format; + format.setVersion(3,2);
+ format.setProfile(QSurfaceFormat::CoreProfile);
+ QSurfaceFormat::setDefaultFormat(format);</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and it \
still works.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">plasmashell unchanged (so still requesting an GL 2.0 context) also still works.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/fadingnode.cpp <span style="color: \
grey">(88b7310641f58c2b74fe61d2c5a97847cf7dc3b8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128426/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7380611518338626935==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic