[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    [Differential] [Commented On] D4799: Delay notifications until desktop session has loaded
From:       Valerio Pilo <noreply () phabricator ! kde ! org>
Date:       2017-02-26 21:08:41
Message-ID: 20170226210840.21189.32140.87E2862E () phabricator ! kde ! org
[Download RAW message or body]

vpilo added a comment.


  In https://phabricator.kde.org/D4799#90169, @dfaure wrote:
  
  > About the code in kded that calls ksplash: that code is obsolete and currently \
only kept for compatibility reasons, see https://git.reviewboard.kde.org/r/129010/  > \
IOW you can ignore that code completely.  
  
  OK, thanks :)
  
  In https://phabricator.kde.org/D4799#90165, @broulik wrote:
  
  > Most are not, however. PowerDevil, for instance, actually delays its \
notifications (e.g. you startup with a low battery) until a notification service \
registers itself to avoid the embarrassing popup ontop of KSplash while still showing \
the notification soon after logging in. Almost anything else ("You are now connected \
to network X") is pointless, and I hate this Yakuake notification when logging in.  
  
  All notifications can be disabled if the user finds them useless and/or annoying - \
not a reason to prevent them from showing at all by means of frameworks, though, \
IMHO. And we can't expect the applications to all do what PowerDevil does. Unless we \
make this change happen (with another trigger to decide whether the splash is being \
shown).

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D4799

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: vpilo
Cc: dfaure, broulik, graesslin, mck182, #frameworks


[Attachment #3 (text/html)]

<table><tr><td style="">vpilo added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4799" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D4799#90169" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D4799#90169</a>, <a \
href="https://phabricator.kde.org/p/dfaure/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@dfaure</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>About the code in kded that calls ksplash: \
that code is obsolete and currently only kept for compatibility reasons, see <a \
href="https://git.reviewboard.kde.org/r/129010/" class="remarkup-link" \
target="_blank" rel="noreferrer">https://git.reviewboard.kde.org/r/129010/</a><br />  \
IOW you can ignore that code completely.</p></div> </blockquote>

<p>OK, thanks :)</p>

<blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D4799#90165" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D4799#90165</a>, <a \
href="https://phabricator.kde.org/p/broulik/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@broulik</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Most are not, however. PowerDevil, for \
instance, actually delays its notifications (e.g. you startup with a low battery) \
until a notification service registers itself to avoid the embarrassing popup ontop \
of KSplash while still showing the notification soon after logging in. Almost \
anything else (&quot;You are now connected to network X&quot;) is pointless, and I \
hate this Yakuake notification when logging in.</p></div> </blockquote>

<p>All notifications can be disabled if the user finds them useless and/or annoying - \
not a reason to prevent them from showing at all by means of frameworks, though, \
IMHO. And we can&#039;t expect the applications to all do what PowerDevil does. \
Unless we make this change happen (with another trigger to decide whether the splash \
is being shown).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R289 \
KNotifications</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4799" \
rel="noreferrer">https://phabricator.kde.org/D4799</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>vpilo<br /><strong>Cc: </strong>dfaure, broulik, \
graesslin, mck182, Frameworks<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]