From kde-frameworks-devel Sun Feb 26 20:47:08 2017 From: Vishesh Handa Date: Sun, 26 Feb 2017 20:47:08 +0000 To: kde-frameworks-devel Subject: Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly Message-Id: <20170226204708.3284.34719 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=148814203422491 --===============0398845538505191031== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/ ----------------------------------------------------------- (Updated Feb. 26, 2017, 8:47 p.m.) Status ------ This change has been discarded. Review request for KDE Frameworks. Bugs: 340819 https://bugs.kde.org/show_bug.cgi?id=340819 Repository: kunitconversion Description ------- Currency: Fetch the currency file properly Properly run an event loop and wait for the file to be fetched. Also add a test to make sure currency conversion is working. This patch also contains - * https://git.reviewboard.kde.org/r/122182/ * https://git.reviewboard.kde.org/r/122181/ * https://git.reviewboard.kde.org/r/122180/ This is because reviewboard refuses to upload only a part of the diff. Please only look at currency.cpp w.r.t the EventLoop. Diffs ----- autotests/convertertest.h 8129a48 autotests/convertertest.cpp ae4298e src/currency.cpp 715233c Diff: https://git.reviewboard.kde.org/r/122183/diff/ Testing ------- Test now passes. Thanks, Vishesh Handa --===============0398845538505191031== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/

This change has been discarded.

Review request for KDE Frameworks.

By Vishesh Handa.

Updated Feb. 26, 2017, 8:47 p.m.

Bugs: 340819

Repository: kunitconversion

Description

Currency: Fetch the currency file properly

Properly run an event loop and wait for the file to be fetched.

Also add a test to make sure currency conversion is working.

This patch also contains - https://git.reviewboard.kde.org/r/122182/ https://git.reviewboard.kde.org/r/122181/ * https://git.reviewboard.kde.org/r/122180/

This is because reviewboard refuses to upload only a part of the diff. Please only look at currency.cpp w.r.t the EventLoop.

Testing

Test now passes.

Diffs

autotests/convertertest.h (8129a48)
autotests/convertertest.cpp (ae4298e)
src/currency.cpp (715233c)

--===============0398845538505191031==--