[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animated
From: Fabio D'Urso <fabiodurso () hotmail ! it>
Date: 2017-02-26 0:11:48
Message-ID: 20170226001148.23555.20032 () mimi ! kde ! org
[Download RAW message or body]
--===============3530783443311458063==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120160/
-----------------------------------------------------------
(Updated Feb. 26, 2017, 12:11 a.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks, Christoph Feck and Aurélien Gâteau.
Repository: kwidgetsaddons
Description
-------
Hi, I've found that if you call animatedShow() immediatly after animatedHide(), without waiting for the \
hide animation to finish first, the hide animation goes on and, in the end, the message widget becomes \
hidden.
The attached patch adds checks in animatedShow and animatedHide so that, if an opposite animation is \
currently running, they just reverse it.
Diffs
-----
autotests/kmessagewidgetautotest.h 062e2b3
autotests/kmessagewidgetautotest.cpp f46bab0
src/kmessagewidget.cpp bc7ba32
tests/kmessagewidgettest.cpp f621b5a
Diff: https://git.reviewboard.kde.org/r/120160/diff/
Testing
-------
I've added buttons to invoke animatedShow and animatedHide in tests/kmessagewidget.cpp and used them to \
test the behavior.
I've also added an autotest that checks the final height and isVisible() value, both after single \
animatedShow/animatedHide calls and after animatedShow+animatedHide and animatedHide+animatedShow.
Thanks,
Fabio D'Urso
--===============3530783443311458063==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120160/">https://git.reviewboard.kde.org/r/120160/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Christoph Feck and Aurélien Gâteau.</div>
<div>By Fabio D'Urso.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2017, 12:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, I've found that if you call \
animatedShow() immediatly after animatedHide(), without waiting for the hide animation to finish first, \
the hide animation goes on and, in the end, the message widget becomes hidden.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The attached patch adds \
checks in animatedShow and animatedHide so that, if an opposite animation is currently running, they just \
reverse it.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I've added buttons to invoke animatedShow \
and animatedHide in tests/kmessagewidget.cpp and used them to test the behavior.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've also added an \
autotest that checks the final height and isVisible() value, both after single animatedShow/animatedHide \
calls and after animatedShow+animatedHide and animatedHide+animatedShow.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kmessagewidgetautotest.h <span style="color: grey">(062e2b3)</span></li>
<li>autotests/kmessagewidgetautotest.cpp <span style="color: grey">(f46bab0)</span></li>
<li>src/kmessagewidget.cpp <span style="color: grey">(bc7ba32)</span></li>
<li>tests/kmessagewidgettest.cpp <span style="color: grey">(f621b5a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120160/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3530783443311458063==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic