[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Finding contributor email is imposible - was - Re: Phabricator: All repositories registered - up
From:       Fredrik =?iso-8859-1?q?H=F6glund?= <fredrik () kde ! org>
Date:       2017-02-07 15:03:59
Message-ID: 201702071604.00542.fredrik () kde ! org
[Download RAW message or body]

On Monday 06 February 2017, Albert Astals Cid wrote:
> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure:
> > Hi everyone,
> > 
> > From this point forward, communities should be moving away from
> > Reviewboard to Phabricator for conducting code review. Sysadmin will
> > be announcing a timeline for the shutdown of Reviewboard in the near
> > future.
> 
> Today i wanted to commit https://phabricator.kde.org/D4432 since the person 
> that opened it does not have a developer account.
> 
> Easy peasy, it's just a line, i download the patch and then
> 
> git commit --author ...
> 
> and what, it says "Authored by rikmills" that's probably not the guys name, 
> but i can click on the name and on https://phabricator.kde.org/p/rikmills/ i 
> learn he is Rik Mills, good.
> 
> $ git commit --author=="Rik Mills"
> fatal: --author 'Rik Mills' is not 'Name <email>' and matches no existing 
> author
> 
> ouch, so i need his email, where do i get it?
> 
> Nowhere it seems.
> 
> I resorted to searching for it in identity.kde.org but i think that i can only 
> do that because i have some special power over there that allows me to see 
> everyone's email, and even if everyone can, it's very cumbsersome, and 
> probably what i would end up doing is asking in Differential, the author would 
> have to answer, potentially either him or me forgetting about it.
> 
> On reviewboard it was as simple as going to 
> https://git.reviewboard.kde.org/users/rikmills/ (that i just realized i could 
> have used instead of identity :D but it's going away so it's not a solution 
> either).

This is the wrong solution.  Phabricator should provide the patch in a format
that you can apply to the repository with git am -s <patch>, and get the
original commit message, date and author.

You should never have to enter the author or commit message yourself
when you are committing something for someone else.

Fredrik

[prev in list] [next in list] [prev in thread] [next in thread]