[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 122795: Fix crashes when attempting to load invalid package
From: Albert Astals Cid <aacid () kde ! org>
Date: 2017-02-04 11:33:32
Message-ID: 20170204113332.23300.8425 () mimi ! kde ! org
[Download RAW message or body]
--===============6235991966310161724==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122795/#review102371
-----------------------------------------------------------
Patch does not apply anymore.
- Albert Astals Cid
On March 3, 2015, 7:32 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122795/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 7:32 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> AppletQuickItem: don't crash if d->qmlObject->mainComponent() is null
>
> The if branch is entered if d->qmlObject->mainComponent() is null, but then
> it is unconditionally dereferenced causing a potential crash
>
>
> ----
>
> Don't crash if mainscript is missing
>
> ----
> Better error message if applet could not be loaded
>
>
> Diffs
> -----
>
> src/plasmaquick/appletquickitem.cpp 1abedf0d9089c69d12b981d4597363cb1c6fc443
> src/scriptengines/qml/plasmoid/wallpaperinterface.cpp \
> a406d452cadbe6afa6a51a127b6bc98ce137ddae
> Diff: https://git.reviewboard.kde.org/r/122795/diff/
>
>
> Testing
> -------
>
> no longer crashes, prints an error message instead
>
>
> Thanks,
>
> Alex Richardson
>
>
--===============6235991966310161724==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122795/">https://git.reviewboard.kde.org/r/122795/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Patch \
does not apply anymore.</p></pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On March 3rd, 2015, 7:32 p.m. UTC, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated March 3, 2015, 7:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">AppletQuickItem: don't crash if \
d->qmlObject->mainComponent() is null</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The if branch is \
entered if d->qmlObject->mainComponent() is null, but then it is \
unconditionally dereferenced causing a potential crash</p> <hr style="text-rendering: \
inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: \
inherit;" /> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Don't crash if mainscript is missing</p> <hr \
style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px \
solid #ddd;line-height: inherit;" /> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Better error message if \
applet could not be loaded</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">no longer crashes, prints an error message \
instead</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/appletquickitem.cpp <span style="color: \
grey">(1abedf0d9089c69d12b981d4597363cb1c6fc443)</span></li>
<li>src/scriptengines/qml/plasmoid/wallpaperinterface.cpp <span style="color: \
grey">(a406d452cadbe6afa6a51a127b6bc98ce137ddae)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122795/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6235991966310161724==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic