[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal
From:       Anthony Fieroni <bvbfan () abv ! bg>
Date:       2017-01-21 5:52:59
Message-ID: 20170121055259.31352.26693 () mimi ! kde ! org
[Download RAW message or body]

--===============7451326272354958085==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129665/
-----------------------------------------------------------

(Updated Ян. 21, 2017, 7:52 преди обяд)


Review request for KDE Frameworks and Martin Gräßlin.


Changes
-------

Removed warnings in separate commit \
https://cgit.kde.org/knotifications.git/commit/?id=5965b3c6ae438fd9458b9a78c46ab764ccf05e62
 Rebase and clear only minimized window state


Repository: knotifications


Description
-------

I think, we want minized window to be shown as normal when it's closed in tray. Why \
we could want a window to be shown as minimized ?


Diffs (updated)
-----

  src/kstatusnotifieritem.cpp fcbe6a8 

Diff: https://git.reviewboard.kde.org/r/129665/diff/


Testing
-------

+ Remove deprecated warnings


Thanks,

Anthony Fieroni


--===============7451326272354958085==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129665/">https://git.reviewboard.kde.org/r/129665/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Martin Gräßlin.</div>
<div>By Anthony Fieroni.</div>


<p style="color: grey;"><i>Updated Ян. 21, 2017, 7:52 преди обяд</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Removed warnings in separate commit \
https://cgit.kde.org/knotifications.git/commit/?id=5965b3c6ae438fd9458b9a78c46ab764ccf05e62
 Rebase and clear only minimized window state</p></pre>
  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think, we want minized window to be shown as normal \
when it's closed in tray. Why we could want a window to be shown as minimized \
?</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Remove deprecated \
warnings</li> </ul></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kstatusnotifieritem.cpp <span style="color: grey">(fcbe6a8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129665/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============7451326272354958085==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic