[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 129760: Fixup handling of KFontUtils::adaptFontSize's flags' default value.
From:       Shaheed Haque <srhaque () theiet ! org>
Date:       2017-01-20 11:01:52
Message-ID: CAHAc2jfNT2NeKcseQFbA3AvRC_yFrPts-q2QZCgM-iKqpLoFMg () mail ! gmail ! com
[Download RAW message or body]

I've actually switched all activity to KDE/master (I'm presently on
a5f3a76e14799c68b5e8f74e375baa5f6f6ab4dc), so I'll check again when I've
got your latest updates. BTW, one other thing I noticed was this, if I
"make clean" in kguiaddons, src/sip/PyKF5/KGuiAddons/KGuiAddonsmod.sip is
not removed. It is only ever created when cmake is run.

Is this as expected?

On 18 January 2017 at 21:16, Stephen Kelly <steveire@gmail.com> wrote:

> On 01/18/2017 12:41 PM, Shaheed Haque wrote:
> > Hi Steve,
> >
> > I have verified this works on KDE/master, and will close the review.
> >
> > I did see a "funny" in that I had to run CMake twice in a fresh
> > directory before it would run clean. You might want to look into that
> > as it was not clear to me what it CMake is trying to do. Anyway, here
> > is the first unsuccessful run:
>
> Hi Shaheed,
>
> I somehow made my frameworks-bindings repo point to incorrect old sha1s
> for frameworks. I've fixed that now, so you should be able to build all
> of them with a clean build.
>
> Thanks,
>
> Steve.
>
>
>

[Attachment #3 (text/html)]

<div dir="ltr">I&#39;ve actually switched all activity to KDE/master (I&#39;m \
presently on a5f3a76e14799c68b5e8f74e375baa5f6f6ab4dc), so I&#39;ll check again when \
I&#39;ve got your latest updates. BTW, one other thing I noticed was this, if I \
&quot;make clean&quot; in kguiaddons, src/sip/PyKF5/KGuiAddons/KGuiAddonsmod.sip is \
not removed. It is only ever created when cmake is run.<br><br>Is this as \
expected?<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 18 \
January 2017 at 21:16, Stephen Kelly <span dir="ltr">&lt;<a \
href="mailto:steveire@gmail.com" target="_blank">steveire@gmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">On 01/18/2017 12:41 PM, Shaheed Haque wrote:<br> &gt; Hi \
Steve,<br> &gt;<br>
&gt; I have verified this works on KDE/master, and will close the review.<br>
&gt;<br>
&gt; I did see a &quot;funny&quot; in that I had to run CMake twice in a fresh<br>
&gt; directory before it would run clean. You might want to look into that<br>
&gt; as it was not clear to me what it CMake is trying to do. Anyway, here<br>
&gt; is the first unsuccessful run:<br>
<br>
Hi Shaheed,<br>
<br>
I somehow made my frameworks-bindings repo point to incorrect old sha1s<br>
for frameworks. I&#39;ve fixed that now, so you should be able to build all<br>
of them with a clean build.<br>
<br>
Thanks,<br>
<br>
Steve.<br>
<br>
<br>
</blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]