From kde-frameworks-devel Wed Jan 18 21:16:41 2017 From: Stephen Kelly Date: Wed, 18 Jan 2017 21:16:41 +0000 To: kde-frameworks-devel Subject: Re: Review Request 129760: Fixup handling of KFontUtils::adaptFontSize's flags' default value. Message-Id: <3553c693-7107-cd34-4686-4c00aeca0e09 () gmail ! com> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=148477421503172 On 01/18/2017 12:41 PM, Shaheed Haque wrote: > Hi Steve, > > I have verified this works on KDE/master, and will close the review. > > I did see a "funny" in that I had to run CMake twice in a fresh > directory before it would run clean. You might want to look into that > as it was not clear to me what it CMake is trying to do. Anyway, here > is the first unsuccessful run: Hi Shaheed, I somehow made my frameworks-bindings repo point to incorrect old sha1s for frameworks. I've fixed that now, so you should be able to build all of them with a clean build. Thanks, Steve.