[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129202: Handle faulty provider as initialized
From: Andreas Cord-Landwehr <cordlandwehr () kde ! org>
Date: 2017-01-08 10:36:20
Message-ID: 20170108103620.23051.14060 () mimi ! kde ! org
[Download RAW message or body]
--===============2910930620210821292==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Okt. 17, 2016, 8:02 vorm., Aleix Pol Gonzalez wrote:
> > +1 LGTM, unsure of the implications.
I would like to commit that patch after the next KF5 release to give it a full month \
of testing for possible side effects. If anyone objects, please raise your voice \
within the next 7 days.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129202/#review100066
-----------------------------------------------------------
On Okt. 16, 2016, 5:50 nachm., Andreas Cord-Landwehr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129202/
> -----------------------------------------------------------
>
> (Updated Okt. 16, 2016, 5:50 nachm.)
>
>
> Review request for KDE Frameworks, Aleix Pol Gonzalez, Dan Leinir Turthra Jensen, \
> and Jeremy Whiting.
>
> Repository: knewstuff
>
>
> Description
> -------
>
> Always mark a provider as initialized when all initializion steps
> are performed, in particularly when an error occured. This ensures
> that the UI is correctly updated when the initialization steps finished.
>
>
> Diffs
> -----
>
> src/attica/atticaprovider.cpp bc590ce2a2170f69d0b6d8049f7d5da5d0c1d0cd
>
> Diff: https://git.reviewboard.kde.org/r/129202/diff/
>
>
> Testing
> -------
>
> manual testing
>
>
> Thanks,
>
> Andreas Cord-Landwehr
>
>
--===============2910930620210821292==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129202/">https://git.reviewboard.kde.org/r/129202/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Oktober 17th, 2016, 8:02 vorm. UTC, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">+1 LGTM, unsure of the implications.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would like to commit that patch after the next KF5 release to give it a full month of \
testing for possible side effects. If anyone objects, please raise your voice within \
the next 7 days.</p></pre> <br />
<p>- Andreas</p>
<br />
<p>On Oktober 16th, 2016, 5:50 nachm. UTC, Andreas Cord-Landwehr wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Aleix Pol Gonzalez, Dan Leinir Turthra \
Jensen, and Jeremy Whiting.</div> <div>By Andreas Cord-Landwehr.</div>
<p style="color: grey;"><i>Updated Okt. 16, 2016, 5:50 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Always mark a provider as initialized when all initializion steps are \
performed, in particularly when an error occured. This ensures that the UI is \
correctly updated when the initialization steps finished.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">manual testing</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/attica/atticaprovider.cpp <span style="color: \
grey">(bc590ce2a2170f69d0b6d8049f7d5da5d0c1d0cd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129202/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2910930620210821292==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic