[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129709: Fix checking for valid date entered
From: David Jarvie <djarvie () kde ! org>
Date: 2016-12-31 0:13:33
Message-ID: 20161231001333.27201.77809 () mimi ! kde ! org
[Download RAW message or body]
--===============5410807243544758197==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129709/
-----------------------------------------------------------
(Updated Dec. 31, 2016, 12:13 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and John Layt.
Changes
-------
Submitted with commit 1550b2c83f4842eb491b906ff7029fc11fd07d8a by David Jarvie to \
branch master.
Repository: kwidgetsaddons
Description
-------
Checks to determine whether an entered date is valid are wrong or missing in various \
places in the code. This is due to:
- not testing if a minimum or maximum date is set before comparing a date to the \
minimum/maximum;
- always rejecting new minimum/maximum dates if the other maximum/minimum date is not \
set;
- not testing dates for validity when set by the date picker or menu.
This results in the following bugs currently:
- When an up/down arrow or page up/down key is pressed to change the date, and the \
minimum and maximum dates are not set, it is always considered invalid and the date \
is not changed.
- When the DateKeywords option is set, and the minimum and maximum dates are not set, \
the only date which is displayed in the menu is "No Date".
- setMinimumDate() and resetMinimumDate() do nothing if no maximum date is currently \
set.
- setMaximumDate() and resetMaximumDate() do nothing if no minimum date is currently \
set.
- resetDateRange() does nothing.
This patch fixes the above bugs.
Documentation comments in the header file are also improved.
Diffs
-----
autotests/kdatecomboboxtest.cpp c15525a
src/kdatecombobox.h d9a20ca
src/kdatecombobox.cpp ad1d085
Diff: https://git.reviewboard.kde.org/r/129709/diff/
Testing
-------
Updated autotests pass. GUI changes tested with KAlarm, including setting \
DateKeywords. The bugs described above are now fixed.
Thanks,
David Jarvie
--===============5410807243544758197==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129709/">https://git.reviewboard.kde.org/r/129709/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and John Layt.</div>
<div>By David Jarvie.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2016, 12:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 1550b2c83f4842eb491b906ff7029fc11fd07d8a by David \
Jarvie to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Checks to determine whether an entered date is valid \
are wrong or missing in various places in the code. This is due to:
- not testing if a minimum or maximum date is set before comparing a date to the \
minimum/maximum;
- always rejecting new minimum/maximum dates if the other maximum/minimum date is not \
set;
- not testing dates for validity when set by the date picker or menu.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This results in the following bugs \
currently:
- When an up/down arrow or page up/down key is pressed to change the date, and the \
minimum and maximum dates are not set, it is always considered invalid and the date \
is not changed.
- When the DateKeywords option is set, and the minimum and maximum dates are not set, \
the only date which is displayed in the menu is "No Date".
- setMinimumDate() and resetMinimumDate() do nothing if no maximum date is currently \
set.
- setMaximumDate() and resetMaximumDate() do nothing if no minimum date is currently \
set.
- resetDateRange() does nothing.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch fixes the above bugs.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Documentation comments in the header file are also improved.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Updated autotests pass. GUI changes tested with \
KAlarm, including setting DateKeywords. The bugs described above are now \
fixed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kdatecomboboxtest.cpp <span style="color: grey">(c15525a)</span></li>
<li>src/kdatecombobox.h <span style="color: grey">(d9a20ca)</span></li>
<li>src/kdatecombobox.cpp <span style="color: grey">(ad1d085)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129709/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5410807243544758197==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic