[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129628: knewstuff - install missing headers
From: David Faure <faure () kde ! org>
Date: 2016-12-20 9:26:24
Message-ID: 20161220092624.6043.63100 () mimi ! kde ! org
[Download RAW message or body]
--===============7954192774606085976==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129628/#review101515
-----------------------------------------------------------
src/CMakeLists.txt (line 103)
<https://git.reviewboard.kde.org/r/129628/#comment67954>
It's already installed, see this line. No need to install it twice.
- David Faure
On Dec. 9, 2016, 1:28 a.m., José Manuel Santamaría Lema wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129628/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 1:28 a.m.)
>
>
> Review request for KDE Frameworks and Dan Leinir Turthra Jensen.
>
>
> Repository: knewstuff
>
>
> Description
> -------
>
> This patch installs a couple of missing headers:
>
> * knewstuffcore_export.h - which is #include'd from many files in \
> /include/KF5/KNewStuff3/knscore/
> * entry.h - this is #include'd from \
> /usr/include/KF5/KNewStuff3/knscore/entryinternal.h as "../entry.h"
> If the "entry.h" part of the patch is fine, maybe this commit should be reverted:
> https://cgit.kde.org/knewstuff.git/commit/?id=7a644d7147edb816b69fa973630cea6aa72bc3ef
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 79ef39b
> src/core/CMakeLists.txt c2a1a24
>
> Diff: https://git.reviewboard.kde.org/r/129628/diff/
>
>
> Testing
> -------
>
> I just ran a test from the kubuntu package meant to check that all the needed \
> headers are available.
>
> Thanks,
>
> José Manuel Santamaría Lema
>
>
--===============7954192774606085976==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129628/">https://git.reviewboard.kde.org/r/129628/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129628/diff/1/?file=487130#file487130line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">100</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
${CMAKE_CURRENT_BINARY_DIR}/knewstuff_export.h</pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">103</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
${CMAKE_CURRENT_BINARY_DIR}/knewstuff_export.h</pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's \
already installed, see this line. No need to install it twice.</p></pre> </div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On December 9th, 2016, 1:28 a.m. UTC, José Manuel Santamaría Lema wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Dan Leinir Turthra Jensen.</div>
<div>By José Manuel Santamaría Lema.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2016, 1:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch installs a couple of missing headers:</p> \
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">knewstuffcore_export.h - which is \
#include'd from many files in /include/KF5/KNewStuff3/knscore/</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">entry.h - this is #include'd from \
/usr/include/KF5/KNewStuff3/knscore/entryinternal.h as "../entry.h"</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If the "entry.h" part of the patch is fine, maybe this \
commit should be reverted: \
https://cgit.kde.org/knewstuff.git/commit/?id=7a644d7147edb816b69fa973630cea6aa72bc3ef</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I just ran a test from the kubuntu package meant to \
check that all the needed headers are available.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(79ef39b)</span></li>
<li>src/core/CMakeLists.txt <span style="color: grey">(c2a1a24)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129628/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7954192774606085976==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic