From kde-frameworks-devel Thu Dec 08 11:43:44 2016 From: =?utf-8?q?Sebastian_K=C3=BCgler?= Date: Thu, 08 Dec 2016 11:43:44 +0000 To: kde-frameworks-devel Subject: Re: Review Request 129607: Display Application version in About dialog header Message-Id: <20161208114344.13487.47774 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=148119743416608 --===============0578286755185899297== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/#review101330 ----------------------------------------------------------- Ship it! Ship It! - Sebastian Kügler On Dec. 7, 2016, 11:31 a.m., Jean-Baptiste Mardelle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129607/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 11:31 a.m.) > > > Review request for KDE Frameworks, KDE Usability and Sebastian Kügler. > > > Repository: kxmlgui > > > Description > ------- > > Last year, a change in kaboutapplicationdialog (review 124133) moved the application version in a separate tab. However for applications, it is really annoying (several Kdenlive users complained and I fully agree) to not have this information clearly displayed as soon as the About dialog is displayed. I understand the interest of having a separate version tab displaying the various underlying libraries used, but I propose to display again the application version in the About dialog header (see screenshot). > > > Diffs > ----- > > src/kaboutapplicationdialog.cpp 156410e > > Diff: https://git.reviewboard.kde.org/r/129607/diff/ > > > Testing > ------- > > Reverts a recent change, tested and works. > > > File Attachments > ---------------- > > About dialog with version > https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png > Updated patch > https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png > renamed to libraries > https://git.reviewboard.kde.org/media/uploaded/files/2016/12/07/f01ed0c3-1391-48cf-a153-a177d9a7b54a__about3.png > > > Thanks, > > Jean-Baptiste Mardelle > > --===============0578286755185899297== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/

Ship it!

Ship It!

- Sebastian Kügler


On December 7th, 2016, 11:31 a.m. UTC, Jean-Baptiste Mardelle wrote:

Review request for KDE Frameworks, KDE Usability and Sebastian Kügler.
By Jean-Baptiste Mardelle.

Updated Dec. 7, 2016, 11:31 a.m.

Repository: kxmlgui

Description

Last year, a change in kaboutapplicationdialog (review 124133) moved the application version in a separate tab. However for applications, it is really annoying (several Kdenlive users complained and I fully agree) to not have this information clearly displayed as soon as the About dialog is displayed. I understand the interest of having a separate version tab displaying the various underlying libraries used, but I propose to display again the application version in the About dialog header (see screenshot).

Testing

Reverts a recent change, tested and works.

Diffs

  • src/kaboutapplicationdialog.cpp (156410e)

View Diff

File Attachments

  • About dialog with version
  • Updated patch
  • renamed to libraries
  • --===============0578286755185899297==--