From kde-frameworks-devel Mon Dec 05 23:33:45 2016 From: Lamarque Souza Date: Mon, 05 Dec 2016 23:33:45 +0000 To: kde-frameworks-devel Subject: Re: Review Request 129607: Display Application version in About dialog header Message-Id: <20161205233345.13487.50160 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=148098083222545 --===============1620350545721876167== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Dec. 3, 2016, 4:48 p.m., Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" label from inside the tab? > > > > Also, +1 to putting the version front. > > Thomas Pfeiffer wrote: > Hm, "Using" sounds a bit weird without context, but "Libraries" or maybe "Libraries used" makes sense to me. The only thing that would not really fit from a purely technical perspective is the windowing system used (though that does not fit in "Version" either because it does not say anything about its version), but I don't think that is a problem. > > Martin Klapetek wrote: > "Running with" / "Running on" are some other ideas. In any case, I think the "Using" label should now go as its purpose would be now covered by the tab title. What about "Platform" for the title of the tab? - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/#review101247 ----------------------------------------------------------- On Dec. 3, 2016, 1:39 p.m., Jean-Baptiste Mardelle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129607/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2016, 1:39 p.m.) > > > Review request for KDE Frameworks, KDE Usability and Sebastian Kügler. > > > Repository: kxmlgui > > > Description > ------- > > Last year, a change in kaboutapplicationdialog (review 124133) moved the application version in a separate tab. However for applications, it is really annoying (several Kdenlive users complained and I fully agree) to not have this information clearly displayed as soon as the About dialog is displayed. I understand the interest of having a separate version tab displaying the various underlying libraries used, but I propose to display again the application version in the About dialog header (see screenshot). > > > Diffs > ----- > > src/kaboutapplicationdialog.cpp 156410e > > Diff: https://git.reviewboard.kde.org/r/129607/diff/ > > > Testing > ------- > > Reverts a recent change, tested and works. > > > File Attachments > ---------------- > > About dialog with version > https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/c02f4767-2a74-4c25-8599-de410678867e__about.png > Updated patch > https://git.reviewboard.kde.org/media/uploaded/files/2016/12/03/ee13cb47-2162-4be7-8255-3dce7f470c2b__about2.png > > > Thanks, > > Jean-Baptiste Mardelle > > --===============1620350545721876167== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129607/

On December 3rd, 2016, 4:48 p.m. UTC, Martin Klapetek wrote:

How about "Using" for the title of the tab and then removing the "Using" label from inside the tab?


Also, +1 to putting the version front.

On December 5th, 2016, 11:10 p.m. UTC, Thomas Pfeiffer wrote:

Hm, "Using" sounds a bit weird without context, but "Libraries" or maybe "Libraries used" makes sense to me. The only thing that would not really fit from a purely technical perspective is the windowing system used (though that does not fit in "Version" either because it does not say anything about its version), but I don't think that is a problem.

On December 5th, 2016, 11:26 p.m. UTC, Martin Klapetek wrote:

"Running with" / "Running on" are some other ideas. In any case, I think the "Using" label should now go as its purpose would be now covered by the tab title.
What about "Platform" for the title of the tab?

- Lamarque


On December 3rd, 2016, 1:39 p.m. UTC, Jean-Baptiste Mardelle wrote:

Review request for KDE Frameworks, KDE Usability and Sebastian Kügler.
By Jean-Baptiste Mardelle.

Updated Dec. 3, 2016, 1:39 p.m.

Repository: kxmlgui

Description 

Last year, a change in kaboutapplicationdialog (review 124133) moved the application version in a separate tab. However for applications, it is really annoying (several Kdenlive users complained and I fully agree) to not have this information clearly displayed as soon as the About dialog is displayed. I understand the interest of having a separate version tab displaying the various underlying libraries used, but I propose to display again the application version in the About dialog header (see screenshot).

Testing 

Reverts a recent change, tested and works.

Diffs

  • src/kaboutapplicationdialog.cpp (156410e)

View Diff

File Attachments

  • About dialog with version
  • Updated patch
    		•
    --===============1620350545721876167==--