[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on
From: Albert Astals Cid <aacid () kde ! org>
Date: 2016-12-02 22:52:01
Message-ID: 20161202225201.23280.88662 () mimi ! kde ! org
[Download RAW message or body]
--===============9179987494693830113==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Dec. 1, 2016, 9:43 p.m., Albert Astals Cid wrote:
> > src/kstatusnotifieritem.cpp, line 972
> > <https://git.reviewboard.kde.org/r/127216/diff/7/?file=485236#file485236line972>
> >
> > maybe move this to the else?
>
> Anthony Fieroni wrote:
> NET::WMFrameExtents is not needed anymore.
>
> Anthony Fieroni wrote:
> info is used on 977 and 984 is two 'else' braches :)
Right, i missed one.
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review101203
-----------------------------------------------------------
On Nov. 13, 2016, 5:17 a.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2016, 5:17 a.m.)
>
>
> Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.
>
>
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> Store position of widget before hide it
>
>
> Diffs
> -----
>
> src/kstatusnotifieritem.cpp 3eb39b2
> src/kstatusnotifieritemprivate_p.h 8fdfd4c
>
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
>
>
> Testing
> -------
>
> Tested on pixel ratio = 1 with Amarok, Kmail, Akregator, Kalarm, Ktimer
> Close with 'X' - restore in correct pos
> Hide by click at icon in systray - restore correct pos
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============9179987494693830113==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127216/">https://git.reviewboard.kde.org/r/127216/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 1st, 2016, 9:43 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127216/diff/7/?file=485236#file485236line972" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kstatusnotifieritem.cpp</a> <span style="font-weight: normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">950</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KWindowInfo</span> <span class="n">i<span class="hl">nfo</span></span><span \
class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> \
</span><span class="n"><span class="hl">KWindowSystem</span></span><span \
class="o"><span class="hl">::</span></span><span class="n"><span \
class="hl">windowI</span>nfo</span><span class="p">(</span><span \
class="n">associatedWidget</span><span class="o">-></span><span \
class="n">winId</span><span class="p">(),</span> <span class="n">NET</span><span \
class="o">::</span><span class="n">WMDesktop</span><span class="hl"> </span><span \
class="o"><span class="hl">|</span></span><span class="hl"> </span><span \
class="n"><span class="hl">NET</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span \
class="hl">WMFrameExtents</span></span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">972</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KWindowInfo</span> <span class="n">info</span><span class="p">(</span><span \
class="n">associatedWidget</span><span class="o">-></span><span \
class="n">winId</span><span class="p">(),</span> <span class="n">NET</span><span \
class="o">::</span><span class="n">WMDesktop</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">maybe \
move this to the else?</p></pre> </blockquote>
<p>On December 2nd, 2016, 8:38 a.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">NET::WMFrameExtents is not needed anymore.</p></pre> </blockquote>
<p>On December 2nd, 2016, 8:43 a.m. UTC, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">info \
is used on 977 and 984 is two 'else' braches :)</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Right, i missed one.</p></pre> <br />
<p>- Albert</p>
<br />
<p>On November 13th, 2016, 5:17 a.m. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Nov. 13, 2016, 5:17 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=356523">356523</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Store position of widget before hide it</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested on pixel ratio = 1 with Amarok, Kmail, \
Akregator, Kalarm, Ktimer Close with 'X' - restore in correct pos
Hide by click at icon in systray - restore correct pos</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kstatusnotifieritem.cpp <span style="color: grey">(3eb39b2)</span></li>
<li>src/kstatusnotifieritemprivate_p.h <span style="color: \
grey">(8fdfd4c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127216/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9179987494693830113==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic