[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129560: More utempter path searching
From: Rohan Garg <rohangarg () kubuntu ! org>
Date: 2016-11-25 16:36:39
Message-ID: 20161125163639.11805.55668 () mimi ! kde ! org
[Download RAW message or body]
--===============6613733249946335846==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129560/#review101119
-----------------------------------------------------------
Ship it!
Yay! Diff seems to be fixed now :)
- Rohan Garg
On Nov. 25, 2016, 10:04 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129560/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2016, 10:04 p.m.)
>
>
> Review request for KDE Frameworks and Rohan Garg.
>
>
> Repository: kpty
>
>
> Description
> -------
>
> Debian stable still has it in /usr/lib/utempter/ so search there
>
> Also I don't think it wants to use CMAKE_PREFIX_PATH which is empty by default, I \
> think this was intended to be CMAKE_INSTALL_PREFIX
> old review: https://git.reviewboard.kde.org/r/129090/
>
>
> Diffs
> -----
>
> cmake/FindUTEMPTER.cmake c5a1e41
>
> Diff: https://git.reviewboard.kde.org/r/129560/diff/
>
>
> Testing
> -------
>
> now it finds utempter in Debian stable (jessie)
>
>
> Thanks,
>
> Jonathan Riddell
>
>
--===============6613733249946335846==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129560/">https://git.reviewboard.kde.org/r/129560/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yay! \
Diff seems to be fixed now :)</p></pre> <br />
<p>- Rohan Garg</p>
<br />
<p>On November 25th, 2016, 10:04 p.m. IST, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Rohan Garg.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2016, 10:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kpty
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Debian stable still has it in /usr/lib/utempter/ so \
search there</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also I don't think it wants to use CMAKE_PREFIX_PATH \
which is empty by default, I think this was intended to be CMAKE_INSTALL_PREFIX</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">old review: \
https://git.reviewboard.kde.org/r/129090/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">now it finds utempter in Debian stable \
(jessie)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindUTEMPTER.cmake <span style="color: grey">(c5a1e41)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129560/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6613733249946335846==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic