[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead
From:       Elvis Angelaccio <elvis.angelaccio () kde ! org>
Date:       2016-11-14 18:11:05
Message-ID: 20161114181105.481.42246 () mimi ! kde ! org
[Download RAW message or body]

--===============1988490449539136647==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129405/
-----------------------------------------------------------

Review request for KDE Frameworks, Christoph Feck and David Edmundson.


Repository: kwidgetsaddons


Description
-------

Currently it's not possible to hide widgets in a KCollapsibleGroupBox, because the \
groupbox hides all chidren on collapse event and shows them on expand event.

The rationale was explained in this comment: "when collapsed hide contents to save \
resources and more importantly get it out the focus chain"

The focus chain problem can be solved by overriding/restoring the focus policy of \
children widgets, without changing their visibility.


Diffs
-----

  src/kcollapsiblegroupbox.cpp 273110e995cb25f28a815cb28125c4678ca2ab28 
  tests/kcollapsiblegroupboxtest.cpp 5a2900e63e42fa81f909c7d1fff0d07033edb025 

Diff: https://git.reviewboard.kde.org/r/129405/diff/


Testing
-------

Test app has been expanded with an hidden checkbox

* Make sure the new checkbox stays hidden after expanding the groupbox.
* With both groups collapsed, make sure the tab-focus goes from the first group to \
the second one (skipping the 7 checkboxes in the first group).


Thanks,

Elvis Angelaccio


--===============1988490449539136647==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129405/">https://git.reviewboard.kde.org/r/129405/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Christoph Feck and David Edmundson.</div>
<div>By Elvis Angelaccio.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently it's not possible to hide widgets in a \
KCollapsibleGroupBox, because the groupbox hides all chidren on collapse event and \
shows them on expand event.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The rationale was explained in this \
comment: "when collapsed hide contents to save resources and more importantly get it \
out the focus chain"</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The focus chain problem can be solved \
by overriding/restoring the focus policy of children widgets, without changing their \
visibility.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Test app has been expanded with an hidden checkbox</p> \
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Make sure the new checkbox stays hidden \
after expanding the groupbox.</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">With both groups \
collapsed, make sure the tab-focus goes from the first group to the second one \
(skipping the 7 checkboxes in the first group).</li> </ul></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kcollapsiblegroupbox.cpp <span style="color: \
grey">(273110e995cb25f28a815cb28125c4678ca2ab28)</span></li>

 <li>tests/kcollapsiblegroupboxtest.cpp <span style="color: \
grey">(5a2900e63e42fa81f909c7d1fff0d07033edb025)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129405/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============1988490449539136647==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic