[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 129385: kwindowsystem add overrides
From:       Allen Winter <winter () kde ! org>
Date:       2016-11-12 17:23:31
Message-ID: 20161112172331.6207.94036 () mimi ! kde ! org
[Download RAW message or body]

--===============0133170738748378005==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129385/
-----------------------------------------------------------

(Updated Nov. 12, 2016, 5:23 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kwindowsystem


Description
-------

Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override


Diffs
-----

  autotests/kwindowsystem_threadtest.cpp a142bae 
  src/kstartupinfo.h 9ed86e4 
  src/platforms/xcb/kselectionowner.h f9ca7e2 
  src/platforms/xcb/kxmessages.cpp 0ca6bbc 

Diff: https://git.reviewboard.kde.org/r/129385/diff/


Testing
-------

all warnings for -Wsuggest-override are gone
make test passes on the same tests as previously.  fyi: a handful of the same autotests fail \
for me with or without this patch.


Thanks,

Allen Winter


--===============0133170738748378005==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129385/">https://git.reviewboard.kde.org/r/129385/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Allen Winter.</div>


<p style="color: grey;"><i>Updated Nov. 12, 2016, 5:23 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add \
Q_DECL_OVERRIDES as suggested by -Wsuggest-override</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">all warnings \
for -Wsuggest-override are gone make test passes on the same tests as previously.  fyi: a \
handful of the same autotests fail for me with or without this patch.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kwindowsystem_threadtest.cpp <span style="color: grey">(a142bae)</span></li>

 <li>src/kstartupinfo.h <span style="color: grey">(9ed86e4)</span></li>

 <li>src/platforms/xcb/kselectionowner.h <span style="color: grey">(f9ca7e2)</span></li>

 <li>src/platforms/xcb/kxmessages.cpp <span style="color: grey">(0ca6bbc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129385/diff/" style="margin-left: 3em;">View \
Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============0133170738748378005==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic