[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 129296: Drop unused KConfig dependency
From:       Aleix Pol Gonzalez <aleixpol () kde ! org>
Date:       2016-10-31 12:52:38
Message-ID: 20161031125238.5235.36792 () mimi ! kde ! org
[Download RAW message or body]

--===============0068771510547327036==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129296/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.


Repository: kpackage


Description
-------

The only place KConfig was used was an unused function: `QVariantMap convert(const \
QString &src)`


Diffs
-----

  CMakeLists.txt 83bb9a4 
  autotests/CMakeLists.txt ca839ce 
  autotests/packagestructuretest.cpp 565c7f4 
  autotests/querytest.cpp 403364f 
  src/kpackage/CMakeLists.txt f6668c7 
  src/kpackage/package.cpp c139031 
  src/kpackage/packageloader.cpp 264f238 
  src/kpackage/private/packagejobthread.cpp ec41cdd 
  src/kpackage/private/packages.cpp 0024058 
  src/kpackagetool/CMakeLists.txt 4977571 
  src/kpackagetool/kpackagetool.cpp e98bbe0 

Diff: https://git.reviewboard.kde.org/r/129296/diff/


Testing
-------

Compiles, tests still pass, everything makes sense.


Thanks,

Aleix Pol Gonzalez


--===============0068771510547327036==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129296/">https://git.reviewboard.kde.org/r/129296/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kpackage
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The only place KConfig was used was an unused \
function: <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">QVariantMap convert(const QString \
&amp;src)</code></p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles, tests still pass, everything makes \
sense.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(83bb9a4)</span></li>

 <li>autotests/CMakeLists.txt <span style="color: grey">(ca839ce)</span></li>

 <li>autotests/packagestructuretest.cpp <span style="color: \
grey">(565c7f4)</span></li>

 <li>autotests/querytest.cpp <span style="color: grey">(403364f)</span></li>

 <li>src/kpackage/CMakeLists.txt <span style="color: grey">(f6668c7)</span></li>

 <li>src/kpackage/package.cpp <span style="color: grey">(c139031)</span></li>

 <li>src/kpackage/packageloader.cpp <span style="color: grey">(264f238)</span></li>

 <li>src/kpackage/private/packagejobthread.cpp <span style="color: \
grey">(ec41cdd)</span></li>

 <li>src/kpackage/private/packages.cpp <span style="color: \
grey">(0024058)</span></li>

 <li>src/kpackagetool/CMakeLists.txt <span style="color: grey">(4977571)</span></li>

 <li>src/kpackagetool/kpackagetool.cpp <span style="color: \
grey">(e98bbe0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129296/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============0068771510547327036==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic