--===============3010409840127830762== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/#review100380 ----------------------------------------------------------- Ship it! if you want to push it already, make sure to omit the other commit for now. - Oswald Buddenhagen On Oct. 20, 2016, 7:52 a.m., Tobias Berner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129122/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 7:52 a.m.) > > > Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald Buddenhagen, and Martin Tobias Holmedahl Sandsmark. > > > Repository: kpty > > > Description > ------- > > FreeBSD does not have `/usr/libexec/*/utempter`. It does however have `/usr/libexec/ulog-helper` [1]. > > It uses `login` instead of `add` and `logout` instead of `del`. > > > [1] https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469&view=markup > > > Diffs > ----- > > cmake/FindUTEMPTER.cmake 4921e58 > src/kpty.cpp 7bf31c3 > > Diff: https://git.reviewboard.kde.org/r/129122/diff/ > > > Testing > ------- > > Builds fine. And it is actually working :) > > > Thanks, > > Tobias Berner > > --===============3010409840127830762== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/

Ship it!

if you want to push it already, make sure to omit the other commit for now.

- Oswald Buddenhagen

On October 20th, 2016, 7:52 a.m. CEST, Tobias Berner wrote:

Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald Buddenhagen, and Martin Tobias Holmedahl Sandsmark.

By Tobias Berner.

Updated Oct. 20, 2016, 7:52 a.m.

Repository: kpty

Description

FreeBSD does not have /usr/libexec/*/utempter. It does however have /usr/libexec/ulog-helper [1].

It uses login instead of add and logout instead of del.

[1] https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469&view=markup

Testing

Builds fine. And it is actually working :)

Diffs

cmake/FindUTEMPTER.cmake (4921e58)
src/kpty.cpp (7bf31c3)

--===============3010409840127830762==--