--===============4532445334552318700== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/#review100338 ----------------------------------------------------------- Ship it! Taro, do you have push rights? Otherwise I or somebody else can push it for you. - Andreas Hartmetz On Oct. 27, 2016, 3:02 p.m., taro yamada wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129259/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 3:02 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 369275 > https://bugs.kde.org/show_bug.cgi?id=369275 > > > Repository: kio > > > Description > ------- > > Currently, KIO uses lstat to get the buffersize for readlink. > But in certain situations, it returns inappropriate value. > > For example, "/proc/self" or "/sys/bus/cpu/devices/*" returns its size is 0 , and then readlink fails with EINVAL.(so link won't be shown in kde application.) > TMSU seems it returns its target's actual filesize insted of the link's filesize itself. > > This patch changes the buffersize to 1024 bytes if it is 0. > And later truncate it to actual size. > > > Diffs > ----- > > src/ioslaves/file/file.cpp 8b17d31 > > Diff: https://git.reviewboard.kde.org/r/129259/diff/ > > > Testing > ------- > > > Thanks, > > taro yamada > > --===============4532445334552318700== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/

Ship it! 

Taro, do you have push rights? Otherwise I or somebody else can push it for you.

- Andreas Hartmetz


On October 27th, 2016, 3:02 p.m. UTC, taro yamada wrote:

Review request for KDE Frameworks.
By taro yamada.

Updated Oct. 27, 2016, 3:02 p.m.

Bugs: 369275
Repository: kio

Description 

Currently, KIO uses lstat to get the buffersize for readlink.
But in certain situations, it returns inappropriate value.


For example, "/proc/self" or "/sys/bus/cpu/devices/*" returns its size is 0 , and then readlink fails with EINVAL.(so link won't be shown in kde application.)
TMSU seems it returns its target's actual filesize insted of the link's filesize itself.


This patch changes the buffersize to 1024 bytes if it is 0.
And later truncate it to actual size.

Diffs

  • src/ioslaves/file/file.cpp (8b17d31)

View Diff
--===============4532445334552318700==--