[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 129246: validate_svg: Increase portability
From:       Raphael Kubo da Costa <rakuco () FreeBSD ! org>
Date:       2016-10-23 15:28:33
Message-ID: 20161023152833.10901.84134 () mimi ! kde ! org
[Download RAW message or body]

--===============8928021691760327279==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129246/
-----------------------------------------------------------

Review request for KDE Frameworks and Jos van den Oever.


Repository: breeze-icons


Description
-------

- Instead of hardcoding the call to the xmllint binary, look for it in
  CMake first and pass its full path to validate_svg.sh.
- Stop creating xmlerrors in the source tree, which is not removed when
  there are no errors in the validation.
- Switch to sh(1) instead of requiring bash, we are just invoking
  find(1) and there is nothing bash-specific in the script.
- Stop setting SVGS in CMake. It increases the configuration time while
  providing no benefit other than perhaps adding the SVG files to an IDE
  project.


Diffs
-----

  CMakeLists.txt 2591a3a0c9c397a729243ceb414251f296895888 
  validate_svg.sh adaf26f95a645b57f8a588fdd49d2281f24b684a 

Diff: https://git.reviewboard.kde.org/r/129246/diff/


Testing
-------

Configuration continues to work, as well as the `breeze-validate-svg` continues \
working.


Thanks,

Raphael Kubo da Costa


--===============8928021691760327279==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129246/">https://git.reviewboard.kde.org/r/129246/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Jos van den Oever.</div>
<div>By Raphael Kubo da Costa.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze-icons
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Instead of hardcoding the call to the xmllint binary, look for it in  \
                CMake first and pass its full path to validate_svg.sh.
- Stop creating xmlerrors in the source tree, which is not removed when
  there are no errors in the validation.
- Switch to sh(1) instead of requiring bash, we are just invoking
  find(1) and there is nothing bash-specific in the script.
- Stop setting SVGS in CMake. It increases the configuration time while
  providing no benefit other than perhaps adding the SVG files to an IDE
  project.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Configuration continues to work, as well as the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">breeze-validate-svg</code> continues working.</p></pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(2591a3a0c9c397a729243ceb414251f296895888)</span></li>

 <li>validate_svg.sh <span style="color: \
grey">(adaf26f95a645b57f8a588fdd49d2281f24b684a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129246/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============8928021691760327279==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic