[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129090: use ECM variables to find binary
From: Rohan Garg <rohangarg () kubuntu ! org>
Date: 2016-10-18 12:56:38
Message-ID: 20161018125638.31521.39578 () mimi ! kde ! org
[Download RAW message or body]
--===============1846113025602048311==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129090/#review100118
-----------------------------------------------------------
Ship it!
Ship It!
- Rohan Garg
On Oct. 18, 2016, 6:25 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129090/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2016, 6:25 p.m.)
>
>
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
>
>
> Repository: kpty
>
>
> Description
> -------
>
> use ECM variables to find binary
>
> currently on debian distros the binary isn't found, we use arch specific \
> directories which aren't search for with the current search string this finds it \
> hidden away in /usr/lib/x86_64-linux-gnu/utempter/utempter
>
> Diffs
> -----
>
> cmake/FindUTEMPTER.cmake 2fc1cd8
>
> Diff: https://git.reviewboard.kde.org/r/129090/diff/
>
>
> Testing
> -------
>
> build, it works
>
>
> Thanks,
>
> Jonathan Riddell
>
>
--===============1846113025602048311==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129090/">https://git.reviewboard.kde.org/r/129090/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Rohan Garg</p>
<br />
<p>On October 18th, 2016, 6:25 p.m. IST, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Oct. 18, 2016, 6:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kpty
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">use ECM variables to find binary</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">currently on debian distros the binary isn't found, we use arch specific \
directories which aren't search for with the current search string this finds it \
hidden away in /usr/lib/x86_64-linux-gnu/utempter/utempter</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">build, it works</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindUTEMPTER.cmake <span style="color: grey">(2fc1cd8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129090/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1846113025602048311==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic