'Re: Review Request 129205: [kcoredirlister] Ability to watch files changes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 129205: [kcoredirlister] Ability to watch files changes
From:       Anthony Fieroni <bvbfan () abv ! bg>
Date:       2016-10-17 12:25:57
Message-ID: 20161017122557.31521.42361 () mimi ! kde ! org
[Download RAW message or body]

--===============4039109102372419555==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129205/
-----------------------------------------------------------

(Updated Oct. 17, 2016, 3:25 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Correct diff


Repository: kio


Description
-------

David, i will discard review if you don't like it, cause watching files changes can \
be *really* expensive. I try to: 1. to not break abi compability
2. to extend filenamesearch with this option
3. to fix https://git.reviewboard.kde.org/r/129141/


Diffs (updated)
-----

  src/core/kcoredirlister.h e6ba2ac 
  src/core/kcoredirlister.cpp 508516e 
  src/core/kcoredirlister_p.h 9a3cc7b 

Diff: https://git.reviewboard.kde.org/r/129205/diff/


Testing
-------

For 3. i still can't figure out why in filenamesearch signal for delete item(s) is \
not triggered. 1. Search for file (by name) in dolphin
2. When appear in view delete him
3. Signal ItemsDeleted is not triggered, file stays in the view even if new search is \
performed and reload is needed. The cache look good, tests pass, works but in \
filenamesearch.


Thanks,

Anthony Fieroni


--===============4039109102372419555==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129205/">https://git.reviewboard.kde.org/r/129205/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Anthony Fieroni.</div>


<p style="color: grey;"><i>Updated Oct. 17, 2016, 3:25 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Correct diff</p></pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">David, i will discard review if you don't like it, \
cause watching files changes can be <em style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">really</em> expensive. I \
try to: 1. to not break abi compability
2. to extend filenamesearch with this option
3. to fix https://git.reviewboard.kde.org/r/129141/</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For 3. i still can't figure out why in filenamesearch \
signal for delete item(s) is not triggered. 1. Search for file (by name) in dolphin
2. When appear in view delete him
3. Signal ItemsDeleted is not triggered, file stays in the view even if new search is \
performed and reload is needed. The cache look good, tests pass, works but in \
filenamesearch.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/kcoredirlister.h <span style="color: grey">(e6ba2ac)</span></li>

 <li>src/core/kcoredirlister.cpp <span style="color: grey">(508516e)</span></li>

 <li>src/core/kcoredirlister_p.h <span style="color: grey">(9a3cc7b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129205/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============4039109102372419555==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic