[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128115: do not load and debug in the same line
From: Harald Sitter <sitter () kde ! org>
Date: 2016-09-28 8:55:50
Message-ID: 20160928085550.8185.6633 () mimi ! kde ! org
[Download RAW message or body]
--===============5762907486713965265==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128115/
-----------------------------------------------------------
(Updated Sept. 28, 2016, 8:55 a.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks and Jeremy Whiting.
Repository: knewstuff
Description
-------
if debugging is off the line is no-op and the load never happens, thus
breaking the test since the entry is always empty.
broke as result of review 126017
do not category debug in test
there's not much gain to be had from making tests less verbose, on the
contrary it might make debugging harder if something fails in an
isolated testbed (e.g. CI)
Diffs
-----
autotests/knewstuffentrytest.cpp a886afc514abfa21b6396a8b2c8c3a88d65b4a5d
Diff: https://git.reviewboard.kde.org/r/128115/diff/
Testing
-------
makes && test passes
Thanks,
Harald Sitter
--===============5762907486713965265==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128115/">https://git.reviewboard.kde.org/r/128115/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Jeremy Whiting.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2016, 8:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">if debugging is off the line is no-op and the load never happens, thus \
breaking the test since the entry is always empty.
broke as result of review 126017
do not category debug in test
there's not much gain to be had from making tests less verbose, on the
contrary it might make debugging harder if something fails in an
isolated testbed (e.g. CI)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">makes && test passes</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/knewstuffentrytest.cpp <span style="color: \
grey">(a886afc514abfa21b6396a8b2c8c3a88d65b4a5d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128115/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5762907486713965265==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic