[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129032: Don't 'inline' public functions to avoid ABI breakage.
From: David Faure <faure () kde ! org>
Date: 2016-09-27 11:03:19
Message-ID: 20160927110319.14576.80731 () mimi ! kde ! org
[Download RAW message or body]
--===============4179260841264196715==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129032/#review99577
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Sept. 26, 2016, 9:41 p.m., José Manuel Santamaría Lema wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129032/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2016, 9:41 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Don't 'inline' public functions to avoid ABI breakage.
>
>
> Diffs
> -----
>
> src/widgets/kpropertiesdialog.h a85037a
> src/widgets/kpropertiesdialog.cpp 5f64478
>
> Diff: https://git.reviewboard.kde.org/r/129032/diff/
>
>
> Testing
> -------
>
> When packaging kio for kubuntu we realized there was a couple of missing symbols \
> which are a couple of deprecated functions, these functions were "inlined" (without \
> using the 'inline' keyword). This is the offending commit:
> https://quickgit.kde.org/?p=kio.git&a=commitdiff&h=b36d368f8004d949597fbe9dc83d6b70418c22f8
>
> From the binary compatibility page "Do's and Don'ts":
> https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#The_Do.27s_and_Don.27ts
> You cannot...
> [...]
> For existing functions of any type:
> [...]
> inline it (this includes moving a member function's body to the class definition, \
> even without the inline keyword).
> The proposed patch moves the functions implementation from the .h file to the .cpp \
> file so this way the binary compatibility is kept.
>
> Thanks,
>
> José Manuel Santamaría Lema
>
>
--===============4179260841264196715==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129032/">https://git.reviewboard.kde.org/r/129032/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Faure</p>
<br />
<p>On September 26th, 2016, 9:41 p.m. UTC, José Manuel Santamaría Lema wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By José Manuel Santamaría Lema.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2016, 9:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Don't 'inline' public functions to avoid ABI \
breakage.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When packaging kio for kubuntu we realized there was a \
couple of missing symbols which are a couple of deprecated functions, these functions \
were "inlined" (without using the 'inline' keyword). This is the offending commit:
https://quickgit.kde.org/?p=kio.git&a=commitdiff&h=b36d368f8004d949597fbe9dc83d6b70418c22f8</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">From the binary compatibility page "Do's and Don'ts": \
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#The_Do.27s_and_Don.27ts
You cannot...
[...]
For existing functions of any type:
[...]
inline it (this includes moving a member function's body to the class definition, \
even without the inline keyword).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The proposed patch \
moves the functions implementation from the .h file to the .cpp file so this way the \
binary compatibility is kept.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/widgets/kpropertiesdialog.h <span style="color: grey">(a85037a)</span></li>
<li>src/widgets/kpropertiesdialog.cpp <span style="color: \
grey">(5f64478)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129032/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4179260841264196715==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic