[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default
From:       Anthony Fieroni <bvbfan () abv ! bg>
Date:       2016-09-15 14:28:16
Message-ID: 20160915142816.18200.79517 () mimi ! kde ! org
[Download RAW message or body]

--===============0596029281048577102==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit



> On Sept. 15, 2016, 4:41 p.m., Kai Uwe Broulik wrote:
> > tests/kmessageboxtest.cpp, line 232
> > <https://git.reviewboard.kde.org/r/128768/diff/1/?file=475432#file475432line232>
> > 
> > QString QString::repeated(int times) const
> > 
> > Returns a copy of this string repeated the specified number of times.

Fix it here https://api.kde.org/frameworks/kwidgetsaddons/html/kmessagebox_8cpp_source.html#l00200



- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128768/#review99217
-----------------------------------------------------------


On Sept. 15, 2016, 1:52 p.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128768/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 1:52 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366569
> https://bugs.kde.org/show_bug.cgi?id=366569
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Hi David,
> 
> K3B use KMessageBox::detailedSorry to show message for not support protocol such as \
> add files from samba, but KMessageBox::detailedSorry hide some part of detailsGroup \
> https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to show it directly \
> by default! 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
> src/kmessagebox.cpp 194ffae 
> tests/kmessageboxtest.cpp 8ea2848 
> 
> Diff: https://git.reviewboard.kde.org/r/128768/diff/
> 
> 
> Testing
> -------
> 
> add case 26 in the patch, for long (> 512) details:
> 
> kwidgetsaddons/build/tests/kmessageboxtest 26
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
> 


--===============0596029281048577102==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128768/">https://git.reviewboard.kde.org/r/128768/</a>
  </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On September 15th, 2016, 4:41 p.m. EEST, <b>Kai \
Uwe Broulik</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  


<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/128768/diff/1/?file=475432#file475432line232" \
style="color: black; font-weight: bold; text-decoration: \
underline;">tests/kmessageboxtest.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">232</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">KMessageBox</span><span class="o">::</span><span \
class="n">detailedSorry</span><span class="p">(</span><span class="mi">0</span><span \
class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">&quot;Sorry, Your harddisk appears to be empty.&quot;</span><span \
class="p">),</span> <span class="n">QStringLiteral</span><span \
class="p">(</span><span class="s">&quot;We don&#39;t know more yet.We don&#39;t know \
more yet.We don&#39;t know more yet.We don&#39;t know more yet.We don&#39;t know more \
yet.We don&#39;t know more yet.We don&#39;t know more yet.We don&#39;t know more \
yet.We don&#39;t know more yet.We don&#39;t know more yet.We don&#39;t know more \
yet.We don&#39;t know more yet.We don&#39;t know more yet.We don&#39;t know more \
yet.We don&#39;t know more yet.We don&#39;t know more yet.We don&#39;t know more \
yet.We don&#39;t know   more yet.We don&#39;t know more yet.We don&#39;t know more \
yet.We don&#39;t know more yet.We don&#39;t know more yet.We don&#39;t know more \
yet.We don&#39;t know more yet.We don&#39;t know more yet.We don&#39;t know more \
yet.We don&#39;t know more yet.We don&#39;t know more yet.We don&#39;t know more \
yet.We don&#39;t know more yet.We don&#39;t know more yet.We don&#39;t know more \
yet.We don&#39;t know more yet.&quot;</span><span class="p">),</span> <span \
class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">&quot;Oops&quot;</span><span class="p">));</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">QString QString::repeated(int times) const</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Returns a copy of this string repeated the specified number of \
times.</p></pre>  </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Fix it here \
https://api.kde.org/frameworks/kwidgetsaddons/html/kmessagebox_8cpp_source.html#l00200</p></pre>
 <br />




<p>- Anthony</p>


<br />
<p>On September 15th, 2016, 1:52 p.m. EEST, Leslie Zhai wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Leslie Zhai.</div>


<p style="color: grey;"><i>Updated Sept. 15, 2016, 1:52 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=366569">366569</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi David,</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">K3B use \
KMessageBox::detailedSorry to show message for not support protocol such as add files \
from samba, but KMessageBox::detailedSorry hide some part of detailsGroup \
https://pbs.twimg.com/media/CqxlXX1W8AAtoee.jpg so it is better to show it directly \
by default!</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Regards, Leslie Zhai</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">add case 26 in the patch, for long (&gt; 512) \
details:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">kwidgetsaddons/build/tests/kmessageboxtest \
26</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kmessagebox.cpp <span style="color: grey">(194ffae)</span></li>

 <li>tests/kmessageboxtest.cpp <span style="color: grey">(8ea2848)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128768/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============0596029281048577102==--


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic