[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128892: Open baloo lmdb database read-only beside in
From: Milian Wolff <mail () milianw ! de>
Date: 2016-09-13 20:02:54
Message-ID: 20160913200254.18200.62985 () mimi ! kde ! org
[Download RAW message or body]
--===============1059564717477664316==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 11, 2016, 9:35 p.m., Vishesh Handa wrote:
> > This is awesome. Ship it.
>
> Christoph Cullmann wrote:
> Lets hope it is awesome correct.
> D
- Milian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128892/#review99115
-----------------------------------------------------------
On Sept. 11, 2016, 9:39 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128892/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2016, 9:39 p.m.)
>
>
> Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> At the moment, any application that uses baloo can corrupt the db.
> Now, only the things that need to write to it open it with read-write.
> This only works as long as the library exposes only read-only things like Query/...
>
>
> Diffs
> -----
>
> src/engine/database.h 6ccb2a5
> src/engine/database.cpp 6a433c7
> src/file/extractor/app.cpp 0ca7276
> src/lib/file.cpp cbbc912
> src/lib/searchstore.cpp 060a4fd
> src/lib/taglistjob.cpp 76ac8ff
> src/qml/experimental/monitor.cpp 11c06ae
> src/tools/balooctl/main.cpp 2a6b175
> src/tools/balooctl/statuscommand.cpp 1a56c64
> src/tools/balooshow/main.cpp f45f2e0
>
> Diff: https://git.reviewboard.kde.org/r/128892/diff/
>
>
> Testing
> -------
>
> Unit tests still work, balooctl seems to do something.
>
>
> Thanks,
>
> Christoph Cullmann
>
>
--===============1059564717477664316==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128892/">https://git.reviewboard.kde.org/r/128892/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 11th, 2016, 9:35 p.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is awesome. Ship it.</p></pre> </blockquote>
<p>On September 11th, 2016, 9:39 p.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Lets \
hope it is awesome correct.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">:D</p></pre> <br />
<p>- Milian</p>
<br />
<p>On September 11th, 2016, 9:39 p.m. UTC, Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh \
Handa.</div> <div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2016, 9:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">At the moment, any application that uses baloo can \
corrupt the db. Now, only the things that need to write to it open it with \
read-write. This only works as long as the library exposes only read-only things like \
Query/...</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Unit tests still work, balooctl seems to do \
something.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/engine/database.h <span style="color: grey">(6ccb2a5)</span></li>
<li>src/engine/database.cpp <span style="color: grey">(6a433c7)</span></li>
<li>src/file/extractor/app.cpp <span style="color: grey">(0ca7276)</span></li>
<li>src/lib/file.cpp <span style="color: grey">(cbbc912)</span></li>
<li>src/lib/searchstore.cpp <span style="color: grey">(060a4fd)</span></li>
<li>src/lib/taglistjob.cpp <span style="color: grey">(76ac8ff)</span></li>
<li>src/qml/experimental/monitor.cpp <span style="color: grey">(11c06ae)</span></li>
<li>src/tools/balooctl/main.cpp <span style="color: grey">(2a6b175)</span></li>
<li>src/tools/balooctl/statuscommand.cpp <span style="color: \
grey">(1a56c64)</span></li>
<li>src/tools/balooshow/main.cpp <span style="color: grey">(f45f2e0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128892/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1059564717477664316==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic