From kde-frameworks-devel Sun Sep 11 21:39:57 2016 From: Christoph Cullmann Date: Sun, 11 Sep 2016 21:39:57 +0000 To: kde-frameworks-devel Subject: Re: Review Request 128892: Open baloo lmdb database read-only beside in Message-Id: <20160911213957.10006.27095 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=147363000904194 --===============1429447862022491080== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/ ----------------------------------------------------------- (Updated Sept. 12, 2016, 12:39 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa. Changes ------- Submitted with commit 02047b524a176da447d8c96e15c7e2abae8339ae by Christoph Cullmann to branch master. Repository: baloo Description ------- At the moment, any application that uses baloo can corrupt the db. Now, only the things that need to write to it open it with read-write. This only works as long as the library exposes only read-only things like Query/... Diffs ----- src/engine/database.h 6ccb2a5 src/engine/database.cpp 6a433c7 src/file/extractor/app.cpp 0ca7276 src/lib/file.cpp cbbc912 src/lib/searchstore.cpp 060a4fd src/lib/taglistjob.cpp 76ac8ff src/qml/experimental/monitor.cpp 11c06ae src/tools/balooctl/main.cpp 2a6b175 src/tools/balooctl/statuscommand.cpp 1a56c64 src/tools/balooshow/main.cpp f45f2e0 Diff: https://git.reviewboard.kde.org/r/128892/diff/ Testing ------- Unit tests still work, balooctl seems to do something. Thanks, Christoph Cullmann --===============1429447862022491080== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/

This change has been marked as submitted.

Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa.
By Christoph Cullmann.

Updated Sept. 12, 2016, 12:39 a.m.

Changes

Submitted with commit 02047b524a176da447d8c96e15c7e2abae8339ae by Christoph Cullmann to branch master.
Repository: baloo

Description 

At the moment, any application that uses baloo can corrupt the db.
Now, only the things that need to write to it open it with read-write.
This only works as long as the library exposes only read-only things like Query/...

Testing 

Unit tests still work, balooctl seems to do something.

Diffs

  • src/engine/database.h (6ccb2a5)
  • src/engine/database.cpp (6a433c7)
  • src/file/extractor/app.cpp (0ca7276)
  • src/lib/file.cpp (cbbc912)
  • src/lib/searchstore.cpp (060a4fd)
  • src/lib/taglistjob.cpp (76ac8ff)
  • src/qml/experimental/monitor.cpp (11c06ae)
  • src/tools/balooctl/main.cpp (2a6b175)
  • src/tools/balooctl/statuscommand.cpp (1a56c64)
  • src/tools/balooshow/main.cpp (f45f2e0)

View Diff
--===============1429447862022491080==--