[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128891: Transaction not created => don't try to abort them
From: Boudhayan Gupta <bgupta () kde ! org>
Date: 2016-09-11 18:55:56
Message-ID: 20160911185556.10006.76612 () mimi ! kde ! org
[Download RAW message or body]
--===============7525004367781613250==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128891/#review99107
-----------------------------------------------------------
Ship it!
LGTM.
Long term I plan to replace all of this with liblmdb++, but that may or may not \
happen soon-ish.
- Boudhayan Gupta
On Sept. 12, 2016, 12:21 a.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128891/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2016, 12:21 a.m.)
>
>
> Review request for KDE Frameworks and Boudhayan Gupta.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Transaction not created => don't try to abort them, avoid wrong usage of lmdb api
>
>
> Diffs
> -----
>
> src/engine/database.cpp 6a433c7
>
> Diff: https://git.reviewboard.kde.org/r/128891/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christoph Cullmann
>
>
--===============7525004367781613250==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128891/">https://git.reviewboard.kde.org/r/128891/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">LGTM.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Long term I plan to replace all of this \
with liblmdb++, but that may or may not happen soon-ish.</p></pre> <br />
<p>- Boudhayan Gupta</p>
<br />
<p>On September 12th, 2016, 12:21 a.m. IST, Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Boudhayan Gupta.</div>
<div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2016, 12:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Transaction not created => don't try to abort them, \
avoid wrong usage of lmdb api</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/engine/database.cpp <span style="color: grey">(6a433c7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128891/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7525004367781613250==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic