From kde-frameworks-devel Sun Sep 11 17:17:38 2016 From: Christoph Cullmann Date: Sun, 11 Sep 2016 17:17:38 +0000 To: kde-frameworks-devel Subject: Re: Review Request 128888: Improve epub extractor, less segfaults Message-Id: <20160911171738.10006.67422 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=147361426632684 --===============3562828574738785031== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128888/ ----------------------------------------------------------- (Updated Sept. 11, 2016, 7:17 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, Boudhayan Gupta and Pinak Ahuja. Changes ------- Submitted with commit 47f6e57b2fa3768feb4f1f4a2cd3ce46660d90f2 by Christoph Cullmann to branch master. Repository: kfilemetadata Description ------- Improve epub extractor: 1) check for more nullpointers (e.g. data can be null for some fields, iterators, ...) 2) actually close the epub file again at all 3) iterator seems to handle clink as stated in docs, fix double free e.g. see bug 361727 could be the double freed clink in the last iterator https://bugs.kde.org/show_bug.cgi?id=361727 Diffs ----- src/extractors/epubextractor.cpp 88a4caa Diff: https://git.reviewboard.kde.org/r/128888/diff/ Testing ------- Unit test still works, no idea how to craft files broken enough to trigger the faults Thanks, Christoph Cullmann --===============3562828574738785031== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128888/

This change has been marked as submitted.

Review request for KDE Frameworks, Boudhayan Gupta and Pinak Ahuja.

By Christoph Cullmann.

Updated Sept. 11, 2016, 7:17 p.m.

Changes

Submitted with commit 47f6e57b2fa3768feb4f1f4a2cd3ce46660d90f2 by Christoph Cullmann to branch master.

Repository: kfilemetadata

Description

Improve epub extractor:

1) check for more nullpointers (e.g. data can be null for some fields, iterators, ...) 2) actually close the epub file again at all 3) iterator seems to handle clink as stated in docs, fix double free

e.g. see bug 361727 could be the double freed clink in the last iterator

https://bugs.kde.org/show_bug.cgi?id=361727

Testing

Unit test still works, no idea how to craft files broken enough to trigger the faults

Diffs

src/extractors/epubextractor.cpp (88a4caa)

--===============3562828574738785031==--