[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Review Request 128885: Increase size limit of baloo index for 64-bit machines
From: Christoph Cullmann <cullmann () kde ! org>
Date: 2016-09-11 10:57:58
Message-ID: 20160911105758.10006.8403 () mimi ! kde ! org
[Download RAW message or body]
--===============4434792324687653395==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128885/
-----------------------------------------------------------
Review request for KDE Frameworks, Boudhayan Gupta, David Faure, and Pinak Ahuja.
Repository: baloo
Description
-------
Increase size limit of baloo index for 64-bit machines to avoid crashs after > 5GB of \
index size. (Better would be additional out-of-space handling, but ATM baloo has zero \
checks for that)
The size limit for 32-bit is still 1GB, like before (there was a silent overflow from \
5GB to 1GB in the computation), people with large homes will still get random \
segfaults on 32-bit.
Patch based on patch from Hao Zhang, Bug 364475
https://bugs.kde.org/show_bug.cgi?id=364475
Diffs
-----
src/engine/database.cpp 89e2e03
src/engine/databasesize.h aa180fb
src/engine/transaction.cpp 0af20be
src/tools/balooctl/statuscommand.cpp 73289c4
Diff: https://git.reviewboard.kde.org/r/128885/diff/
Testing
-------
Thanks,
Christoph Cullmann
--===============4434792324687653395==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128885/">https://git.reviewboard.kde.org/r/128885/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Boudhayan Gupta, David Faure, and Pinak \
Ahuja.</div> <div>By Christoph Cullmann.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Increase size limit of baloo index for 64-bit machines \
to avoid crashs after > 5GB of index size. (Better would be additional \
out-of-space handling, but ATM baloo has zero checks for that)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
size limit for 32-bit is still 1GB, like before (there was a silent overflow from 5GB \
to 1GB in the computation), people with large homes will still get random segfaults \
on 32-bit.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Patch based on patch from Hao Zhang, Bug 364475 \
https://bugs.kde.org/show_bug.cgi?id=364475</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/engine/database.cpp <span style="color: grey">(89e2e03)</span></li>
<li>src/engine/databasesize.h <span style="color: grey">(aa180fb)</span></li>
<li>src/engine/transaction.cpp <span style="color: grey">(0af20be)</span></li>
<li>src/tools/balooctl/statuscommand.cpp <span style="color: \
grey">(73289c4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128885/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4434792324687653395==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic