[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128865: baloo_file crash fix - if database can't be created, try to cleanup and r
From: Christoph Cullmann <cullmann () kde ! org>
Date: 2016-09-08 22:02:12
Message-ID: 20160908220212.5566.82181 () mimi ! kde ! org
[Download RAW message or body]
--===============1422819540371511603==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128865/
-----------------------------------------------------------
(Updated Sept. 8, 2016, 10:02 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and David Faure.
Changes
-------
Submitted with commit a03b0caa4ca1fbfc249bfc0c2730aac340bbf929 by Christoph Cullmann \
to branch master.
Repository: baloo
Description
-------
ATM, I think baloo is missing a lot of checks for "mdb has seen problems".
Easiest case: you have a corrupted index database (easy to reproduce: echo BLA >> \
index in the baloo .local/... directory)
=> start baloo_file => directly crashs
Fix: try to create db, honor success, cleanup, try to create again, if still broken \
=> exit
Diffs
-----
src/file/main.cpp 9410635
Diff: https://git.reviewboard.kde.org/r/128865/diff/
Testing
-------
Corrupted DB via
[cullmann@gekko baloo]$ pwd
/home/cullmann/.local/share/baloo
[cullmann@gekko baloo]$ echo skljdflksjdf >> index
=> started baloo_file
=> old version: will segfault for ever on each start
=> new version: works after cleanup
Thanks,
Christoph Cullmann
--===============1422819540371511603==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128865/">https://git.reviewboard.kde.org/r/128865/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Sept. 8, 2016, 10:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit a03b0caa4ca1fbfc249bfc0c2730aac340bbf929 by \
Christoph Cullmann to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ATM, I think baloo is missing a lot of checks for "mdb \
has seen problems".</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Easiest case: you have a corrupted \
index database (easy to reproduce: echo BLA >> index in the baloo .local/... \
directory)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">=> start baloo_file => directly crashs</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Fix: try to create db, honor success, cleanup, try to create again, if \
still broken => exit</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Corrupted DB via</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">[cullmann@gekko baloo]$ pwd
/home/cullmann/.local/share/baloo
[cullmann@gekko baloo]$ echo skljdflksjdf >> index</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">=> started baloo_file</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">=> \
old version: will segfault for ever on each start => new version: works after \
cleanup</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/main.cpp <span style="color: grey">(9410635)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128865/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1422819540371511603==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic