[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl
From:       Gregor Mi <codestruct () posteo ! org>
Date:       2016-09-06 9:59:10
Message-ID: 20160906095910.5566.4123 () mimi ! kde ! org
[Download RAW message or body]

--===============4911336671508267285==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127111/
-----------------------------------------------------------

(Updated Sept. 6, 2016, 9:59 a.m.)


Review request for KDE Frameworks, Emmanuel Pescosta and Frank Reininghaus.


Changes
-------

- rebase to latest master
- rename signal to urlSelectionRequested
- improve API documentation


Bugs: 335616
    https://bugs.kde.org/show_bug.cgi?id=335616


Repository: kio


Description
-------

Moved logic from https://git.reviewboard.kde.org/r/123253 to here.

Provides a signal to implement bug https://bugs.kde.org/show_bug.cgi?id=335616: \
"Dolphin: Navigate to parent folder selects child folder".


Diffs (updated)
-----

  src/filewidgets/kurlnavigator.h 4ffe56acf9ef7a80ba27ba3a08327e363f98fb0d 
  src/filewidgets/kurlnavigator.cpp 3c045c5aaadb429fd22d28b55ad20d31b086ef48 
  src/filewidgets/urlutil.h PRE-CREATION 
  tests/CMakeLists.txt bc94a4aefd77fb9ce9b2a24075415aac7c30e5ca 
  tests/urlutiltest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127111/diff/


Testing
-------


Thanks,

Gregor Mi


--===============4911336671508267285==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127111/">https://git.reviewboard.kde.org/r/127111/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Emmanuel Pescosta and Frank \
Reininghaus.</div> <div>By Gregor Mi.</div>


<p style="color: grey;"><i>Updated Sept. 6, 2016, 9:59 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">- rebase to latest master
- rename signal to urlSelectionRequested
- improve API documentation</pre>
  </td>
 </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=335616">335616</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Moved logic from \
https://git.reviewboard.kde.org/r/123253 to here.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Provides a signal to implement bug \
https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder \
selects child folder".</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/filewidgets/kurlnavigator.h <span style="color: \
grey">(4ffe56acf9ef7a80ba27ba3a08327e363f98fb0d)</span></li>

 <li>src/filewidgets/kurlnavigator.cpp <span style="color: \
grey">(3c045c5aaadb429fd22d28b55ad20d31b086ef48)</span></li>

 <li>src/filewidgets/urlutil.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/CMakeLists.txt <span style="color: \
grey">(bc94a4aefd77fb9ce9b2a24075415aac7c30e5ca)</span></li>

 <li>tests/urlutiltest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127111/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============4911336671508267285==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic