[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128814: Add Qt5Network as a public dependency.
From: Jeremy Whiting <jpwhiting () kde ! org>
Date: 2016-09-01 20:41:37
Message-ID: 20160901204137.21343.15527 () mimi ! kde ! org
[Download RAW message or body]
--===============4804668032970175311==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128814/#review98825
-----------------------------------------------------------
Ship it!
Ship It!
- Jeremy Whiting
On Sept. 1, 2016, 11:58 a.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128814/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2016, 11:58 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: attica
>
>
> Description
> -------
>
> Attica uses Qt5Network in its public API, so it must declare it as a public
> dependency otherwise consumers could fail to build if Qt5Network is not already
> found elsewhere in the dependency tree.
>
>
> Diffs
> -----
>
> KF5AtticaConfig.cmake.in 078d03c416316fc446b40405cb35f23665f5ed86
>
> Diff: https://git.reviewboard.kde.org/r/128814/diff/
>
>
> Testing
> -------
>
> Consider this test case:
>
> ```cmake
> project(test)
> find_package(ECM 1.7.0 REQUIRED NO_MODULE)
> find_package(KF5Attica REQUIRED)
>
> set(test_SRCS test.cpp)
> add_executable(test ${test_SRCS})
> target_link_libraries(test KF5::Attica)
> ```
>
> Before the change it fails to build with ``ld: cannot find -lQt5::Network``, after \
> the change it passes.
>
> Thanks,
>
> Michael Palimaka
>
>
--===============4804668032970175311==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128814/">https://git.reviewboard.kde.org/r/128814/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Jeremy Whiting</p>
<br />
<p>On September 1st, 2016, 11:58 a.m. MDT, Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2016, 11:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
attica
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Attica uses Qt5Network in its public API, so it must declare it as a \
public dependency otherwise consumers could fail to build if Qt5Network is not \
already found elsewhere in the dependency tree.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Consider this test case:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span \
style="color: #008000">project</span>(<span style="color: #BA2121">test</span>) <span \
style="color: #008000">find_package</span>(<span style="color: #BA2121">ECM</span> \
<span style="color: #BA2121">1.7.0</span> <span style="color: \
#BA2121">REQUIRED</span> <span style="color: #BA2121">NO_MODULE</span>) <span \
style="color: #008000">find_package</span>(<span style="color: \
#BA2121">KF5Attica</span> <span style="color: #BA2121">REQUIRED</span>)
<span style="color: #008000">set</span>(<span style="color: #BA2121">test_SRCS</span> \
<span style="color: #BA2121">test.cpp</span>) <span style="color: \
#008000">add_executable</span>(<span style="color: #BA2121">test</span> <span \
style="color: #666666">${</span><span style="color: #19177C">test_SRCS</span><span \
style="color: #666666">}</span>) <span style="color: \
#008000">target_link_libraries</span>(<span style="color: #BA2121">test</span> <span \
style="color: #BA2121">KF5::Attica</span>) </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Before the change it fails to build with <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">ld: cannot find -lQt5::Network</code>, after the change it \
passes.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5AtticaConfig.cmake.in <span style="color: \
grey">(078d03c416316fc446b40405cb35f23665f5ed86)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128814/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4804668032970175311==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic