[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128790: Call utempter manually
From: Martin Tobias Holmedahl Sandsmark <martin.sandsmark () kde ! org>
Date: 2016-08-28 17:35:34
Message-ID: 20160828173534.27514.9645 () mimi ! kde ! org
[Download RAW message or body]
--===============0323238095943605383==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 28, 2016, 3:24 p.m., Oswald Buddenhagen wrote:
> > src/kpty.cpp, line 165
> > <https://git.reviewboard.kde.org/r/128790/diff/2/?file=475587#file475587line165>
> >
> > hmpf, i'd really prefer this to be a configure/cmake thing rather than a runtime \
> > detection. less runtime code, and allows for a user override (without reading yet \
> > another custom env variable, which sounds really off).
you mean make cmake do the whole figure-out-where-the-executable-is thing? because \
that's beyond my abilities to do. and it doesn't really require yet another \
environment variable, just normal $PATH tweaking afaics.
- Martin Tobias Holmedahl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128790/#review98749
-----------------------------------------------------------
On Aug. 28, 2016, 2:58 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128790/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2016, 2:58 p.m.)
>
>
> Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Rex Dieter, and \
> Thiago Macieira.
>
> Bugs: 364779
> https://bugs.kde.org/show_bug.cgi?id=364779
>
>
> Repository: kpty
>
>
> Description
> -------
>
> According to the investigation in https://bugs.kde.org/show_bug.cgi?id=364779 \
> utempter does stuff in a way that isn't compatible with \
> QProcess/KProcess/KPtyProcess (calling sigaction() before launching its child \
> process).
> So instead we invoke it manually with QProcess.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt caab96f
> src/kpty.cpp 15c3b81
> src/kpty_p.h 192bf1c
>
> Diff: https://git.reviewboard.kde.org/r/128790/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
--===============0323238095943605383==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128790/">https://git.reviewboard.kde.org/r/128790/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 28th, 2016, 3:24 p.m. UTC, <b>Oswald \
Buddenhagen</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128790/diff/2/?file=475587#file475587line165" \
style="color: black; font-weight: bold; text-decoration: underline;">src/kpty.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">165</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">utempterPaths</span> <span class="o"><<</span> <span \
class="n">QStringLiteral</span><span class="p">(</span><span \
class="n">LIBEXEC_DIR</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">hmpf, \
i'd really prefer this to be a configure/cmake thing rather than a runtime detection. \
less runtime code, and allows for a user override (without reading yet another custom \
env variable, which sounds really off).</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">you mean make cmake do the whole figure-out-where-the-executable-is thing? \
because that's beyond my abilities to do. and it doesn't really require yet another \
environment variable, just normal $PATH tweaking afaics.</p></pre> <br />
<p>- Martin Tobias Holmedahl</p>
<br />
<p>On August 28th, 2016, 2:58 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Rex Dieter, and \
Thiago Macieira.</div> <div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2016, 2:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=364779">364779</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kpty
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">According to the investigation in \
https://bugs.kde.org/show_bug.cgi?id=364779 utempter does stuff in a way that isn't \
compatible with QProcess/KProcess/KPtyProcess (calling sigaction() before launching \
its child process).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">So instead we invoke it manually with \
QProcess.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(caab96f)</span></li>
<li>src/kpty.cpp <span style="color: grey">(15c3b81)</span></li>
<li>src/kpty_p.h <span style="color: grey">(192bf1c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128790/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0323238095943605383==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic