'Re: Review Request 128790: Call utempter manually'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 128790: Call utempter manually
From:       Martin Tobias Holmedahl Sandsmark <martin.sandsmark () kde ! org>
Date:       2016-08-28 14:58:45
Message-ID: 20160828145845.27514.18476 () mimi ! kde ! org
[Download RAW message or body]

--===============4453723163489955858==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128790/
-----------------------------------------------------------

(Updated Aug. 28, 2016, 2:58 p.m.)


Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Rex Dieter, and \
Thiago Macieira.


Changes
-------

Changed it to do it manually.


Summary (updated)
-----------------

Call utempter manually


Bugs: 364779
    https://bugs.kde.org/show_bug.cgi?id=364779


Repository: kpty


Description (updated)
-------

According to the investigation in https://bugs.kde.org/show_bug.cgi?id=364779 \
utempter does stuff in a way that isn't compatible with QProcess/KProcess/KPtyProcess \
(calling sigaction() before launching its child process).

So instead we invoke it manually with QProcess.


Diffs (updated)
-----

  src/CMakeLists.txt caab96f 
  src/kpty.cpp 15c3b81 
  src/kpty_p.h 192bf1c 

Diff: https://git.reviewboard.kde.org/r/128790/diff/


Testing
-------


Thanks,

Martin Tobias Holmedahl Sandsmark


--===============4453723163489955858==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128790/">https://git.reviewboard.kde.org/r/128790/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Rex Dieter, and \
Thiago Macieira.</div> <div>By Martin Tobias Holmedahl Sandsmark.</div>


<p style="color: grey;"><i>Updated Aug. 28, 2016, 2:58 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed it to do it manually.</pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Call utempter manually</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=364779">364779</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kpty
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">According to the investigation in \
https://bugs.kde.org/show_bug.cgi?id=364779 utempter does stuff in a way that isn't \
compatible with QProcess/KProcess/KPtyProcess (calling sigaction() before launching \
its child process).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">So instead we invoke it manually with \
QProcess.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: grey">(caab96f)</span></li>

 <li>src/kpty.cpp <span style="color: grey">(15c3b81)</span></li>

 <li>src/kpty_p.h <span style="color: grey">(192bf1c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128790/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============4453723163489955858==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic