'Re: Review Request 128740: uncompress archives in subfolders'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 128740: uncompress archives in subfolders
From:       Jeremy Whiting <jpwhiting () kde ! org>
Date:       2016-08-23 15:26:58
Message-ID: 20160823152658.26193.28859 () mimi ! kde ! org
[Download RAW message or body]

--===============3504229014639644726==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128740/#review98570
-----------------------------------------------------------


Ship it!




Ship It!

- Jeremy Whiting


On Aug. 23, 2016, 8:43 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128740/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2016, 8:43 a.m.)
> 
> 
> Review request for KDE Frameworks, Sebastian Kügler and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> if the archive downloaded by ghns has more than a file inside (either single file \
> or a folder at the root), uncompress it in a folder called the same as the file \
> name (without path or extension) 
> this fixes downloading and installing plasma wallpaper packages (those that provide \
> multiple resolutions). I don't know if this behavior would in turn break other \
> applications, but i don't think so as it seems the behavior changed between kde4 \
> and kf5. if needed i can make it do this only in the case of wallpapers (if \
> (standardResourceDirectory == QLatin1String("wallpaper"))) but i think this should \
> be the correct behavior 
> 
> Diffs
> -----
> 
> src/core/installation.cpp a027418 
> 
> Diff: https://git.reviewboard.kde.org/r/128740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
> 


--===============3504229014639644726==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128740/">https://git.reviewboard.kde.org/r/128740/</a>
  </td>
    </tr>
   </table>
   <br />



<p>

Ship it!

</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />









<p>- Jeremy Whiting</p>


<br />
<p>On August 23rd, 2016, 8:43 a.m. MDT, Marco Martin wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Sebastian Kügler and Jeremy Whiting.</div>
<div>By Marco Martin.</div>


<p style="color: grey;"><i>Updated Aug. 23, 2016, 8:43 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">if the archive downloaded by ghns has more than a file \
inside (either single file or a folder at the root), uncompress it in a folder called \
the same as the file name (without path or extension)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
fixes downloading and installing plasma wallpaper packages (those that provide \
multiple resolutions). I don't know if this behavior would in turn break other \
applications, but i don't think so as it seems the behavior changed between kde4 and \
kf5. if needed i can make it do this only in the case of wallpapers (if \
(standardResourceDirectory == QLatin1String("wallpaper"))) but i think this should be \
the correct behavior</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/installation.cpp <span style="color: grey">(a027418)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128740/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============3504229014639644726==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic