[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126894: Refactor the listjobtest to allow listing of multile paths.
From: David Faure <faure () kde ! org>
Date: 2016-08-13 8:05:07
Message-ID: 20160813080507.10310.62248 () mimi ! kde ! org
[Download RAW message or body]
--===============7256143289484099318==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126894/#review98344
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Jan. 26, 2016, 3:34 p.m., Milian Wolff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126894/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 3:34 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio
>
>
> Description
> -------
>
> With this change it is now possible to list multiple paths
> as defined via the command line.
>
> While at it, I refactored the code to clean it up:
>
> - rely on QEventLoopLocker to quit the application once all jobs
> have finished
> - use a lambda to count the listed entries
> - don't append to a KIO::UDSEntryList to cound the listed entries
>
>
> Diffs
> -----
>
> tests/listjobtest.cpp 702b09950734894a9f82746d58071225419b4e3f
>
> Diff: https://git.reviewboard.kde.org/r/126894/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Milian Wolff
>
>
--===============7256143289484099318==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126894/">https://git.reviewboard.kde.org/r/126894/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Faure</p>
<br />
<p>On January 26th, 2016, 3:34 p.m. UTC, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2016, 3:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With this change it is now possible to list multiple paths as defined \
via the command line.
While at it, I refactored the code to clean it up:
- rely on QEventLoopLocker to quit the application once all jobs
have finished
- use a lambda to count the listed entries
- don't append to a KIO::UDSEntryList to cound the listed entries</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/listjobtest.cpp <span style="color: \
grey">(702b09950734894a9f82746d58071225419b4e3f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126894/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7256143289484099318==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic