[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on
From: Anthony Fieroni <bvbfan () abv ! bg>
Date: 2016-08-04 11:56:43
Message-ID: 20160804115643.20873.51206 () mimi ! kde ! org
[Download RAW message or body]
--===============4081135180036619081==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Април 15, 2016, 6:59 преди обяд, Anthony Fieroni wrote:
> > So as Thomas says in https://git.reviewboard.kde.org/r/127631/ it's a Qt issue, \
> > options are: 1. leave the code as is (i'm not prefer it, the bug is annoying)
> > 2. do it on *right* way storing / restoring the position and when Qt fix the \
> > issue it will *just* work till then windows will be shown depend on KWin \
> > placement policy. Since this policy is user selectable it's not big problem, \
> > about me (i prefer this way) 3. Someone can test this patch with more recent \
> > version of Qt 5.6.1 or 5.7
>
> Anthony Fieroni wrote:
> Same bug present in 5.6.1 and 5.7 :(
Martin G, what can i do to correct it in Qt? Some missing flags, if you know what \
should be done i will do it.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review94623
-----------------------------------------------------------
On Април 10, 2016, 10:48 след обяд, Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> -----------------------------------------------------------
>
> (Updated Април 10, 2016, 10:48 след обяд)
>
>
> Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.
>
>
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> Store position of widget before hide it
>
>
> Diffs
> -----
>
> src/kstatusnotifieritem.cpp 27abfb8
>
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
>
>
> Testing
> -------
>
> Tested on pixel ratio = 1 with Amarok, Kmail, Akregator, Kalarm, Ktimer
> Close with 'X' - restore in correct pos
> Hide by click at icon in systray - restore correct pos
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============4081135180036619081==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127216/">https://git.reviewboard.kde.org/r/127216/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Април 15th, 2016, 6:59 преди обяд \
EEST, <b>Anthony Fieroni</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">So as Thomas says in \
https://git.reviewboard.kde.org/r/127631/ it's a Qt issue, options are: 1. leave the \
code as is (i'm not prefer it, the bug is annoying) 2. do it on <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">right</em> way storing / restoring the position and when Qt fix the issue it \
will <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">just</em> work till then windows will be shown depend \
on KWin placement policy. Since this policy is user selectable it's not big problem, \
about me (i prefer this way) 3. Someone can test this patch with more recent version \
of Qt 5.6.1 or 5.7</p></pre> </blockquote>
<p>On Юни 21st, 2016, 7:16 преди обяд EEST, <b>Anthony Fieroni</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Same bug present in 5.6.1 and 5.7 :(</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Martin G, what can i do to correct it in Qt? Some missing flags, if you \
know what should be done i will do it.</p></pre> <br />
<p>- Anthony</p>
<br />
<p>On Април 10th, 2016, 10:48 след обяд EEST, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Април 10, 2016, 10:48 след \
обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=356523">356523</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Store position of widget before hide it</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested on pixel ratio = 1 with Amarok, Kmail, \
Akregator, Kalarm, Ktimer Close with 'X' - restore in correct pos
Hide by click at icon in systray - restore correct pos</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kstatusnotifieritem.cpp <span style="color: grey">(27abfb8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127216/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4081135180036619081==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic