'Re: Review Request 128413: Add clipboard buttons in the Checksums tab'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 128413: Add clipboard buttons in the Checksums tab
From:       Elvis Angelaccio <elvis.angelaccio () kdemail ! net>
Date:       2016-07-22 21:21:07
Message-ID: 20160722212107.14248.30577 () mimi ! kde ! org
[Download RAW message or body]

--===============0253353094196821376==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128413/
-----------------------------------------------------------

(Updated July 22, 2016, 9:21 p.m.)

Review request for KDE Frameworks, KDE Usability and David Faure.

Changes
-------

Patch rebased.

@dfaure: is this ok code-wise?

Repository: kio

Description
-------

As discussed in RR 128283, we can improve the usability of the dialog if we add \
buttons to interact with the clipboard.

The Paste button is always visible, while the three Copy buttons are hidden until the \
correspoding checksum is computed.

Diffs (updated)
-----

  src/widgets/checksumswidget.ui 543088e 
  src/widgets/kpropertiesdialog.cpp f6d835e 

Diff: https://git.reviewboard.kde.org/r/128413/diff/

Testing
-------

Copy/Paste works as expected.

File Attachments (updated)
----------------

Paste button next to the input field.
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/0b0d3f06-7294-4ff1-b59d-d13c413c00f5__Spectacle.C31997.png
 Example of Copy button
  https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/5f137d47-4592-4f4c-be96-4c2fc3d09978__Spectacle.J32017.png

Thanks,

Elvis Angelaccio

--===============0253353094196821376==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128413/">https://git.reviewboard.kde.org/r/128413/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, KDE Usability and David Faure.</div>
<div>By Elvis Angelaccio.</div>

<p style="color: grey;"><i>Updated July 22, 2016, 9:21 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch rebased.

@dfaure: is this ok code-wise?</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As discussed in RR 128283, we can improve the \
usability of the dialog if we add buttons to interact with the clipboard.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The Paste button is always visible, while the three Copy buttons are hidden \
until the correspoding checksum is computed.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Copy/Paste works as expected.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/widgets/checksumswidget.ui <span style="color: grey">(543088e)</span></li>

 <li>src/widgets/kpropertiesdialog.cpp <span style="color: \
grey">(f6d835e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128413/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/0b0d3f06-7294-4ff1-b59d-d13c413c00f5__Spectacle.C31997.png">Paste \
button next to the input field.</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/5f137d47-4592-4f4c-be96-4c2fc3d09978__Spectacle.J32017.png">Example \
of Copy button</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0253353094196821376==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 